Java: Add commands XGROUP CREATECONSUMER and XGROUP DELCONSUMER
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Does it depend on #359? If yes, please update PR description
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
Base automatically changed from
java/dev_acarbo_add_xgroup_create_destroy
to
java/integ_acarbo_add_xgroup_create_destroy
June 12, 2024 22:18
acarbonetto
changed the base branch from
java/integ_acarbo_add_xgroup_create_destroy
to
java/integ_acarbo_add_xgroup_CREATECONSUMER_DELCONSUMER
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto
force-pushed
the
java/dev_acarbo_add_xgroup_CREATECONSUMER_DELCONSUMER
branch
from
a649ce4
to
a6a37ce
Compare
java/client/src/main/java/glide/api/commands/StreamBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Yury-Fridlyand
approved these changes
Jun 18, 2024
acarbonetto
merged commit b4e9708
into
java/integ_acarbo_add_xgroup_CREATECONSUMER_DELCONSUMER
44 checks passed
acarbonetto
added a commit
that referenced
this pull request
Jun 18, 2024
…360) * Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update Xgroup createconsumer docs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto
deleted the
java/dev_acarbo_add_xgroup_CREATECONSUMER_DELCONSUMER
branch
aaron-congo
pushed a commit
that referenced
this pull request
Jun 19, 2024
…alkey-io#1599) * Java: Add commands `XGROUP CREATECONSUMER` and `XGROUP DELCONSUMER` (#360) * Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update Xgroup createconsumer docs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix doc Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 19, 2024
…alkey-io#1599) * Java: Add commands `XGROUP CREATECONSUMER` and `XGROUP DELCONSUMER` (#360) * Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update Xgroup createconsumer docs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix doc Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
…alkey-io#1599) * Java: Add commands `XGROUP CREATECONSUMER` and `XGROUP DELCONSUMER` (#360) * Add XGROUP CreateConsumer, DelConsumer Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update Xgroup createconsumer docs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix doc Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on valkey-io#1557