Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: remove unused btcUnit from send.tsx #2866

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

NicolaLS
Copy link
Contributor

Remove unused state variable btcUnit from the Send component. Probably it was not noticed that it is not used anymore because the linter does not complain since we set it with getConfig.

Small PR in preparation for send.tsx refactor.

@thisconnect thisconnect self-requested a review August 27, 2024 07:40
@thisconnect
Copy link
Collaborator

nice catch, I believe it was not used anymore since this commit: 38411ca

please link in the commit hash in the commit message.

Remove unused state variable `btcUnit` from the Send component. Probably
it was not noticed that it is not used anymore because the linter does
not complain since we set it with `getConfig`. Not used anymore since:
38411ca
@NicolaLS
Copy link
Contributor Author

@thisconnect amended the commit message

Copy link
Collaborator

@thisconnect thisconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested LGTM

@thisconnect thisconnect merged commit c0ad661 into BitBoxSwiss:master Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants