frontend: create coin control sub-component #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolaLS
force-pushed
the
coin-control-sub-component
branch
2 times, most recently
from
8fb03ee
to
ec4142d
Compare
|
(rebased) |
NicolaLS
force-pushed
the
coin-control-sub-component
branch
2 times, most recently
from
e4c3c44
to
ff0dfd4
Compare
|
rebased / also amended the commit message to explain the change from #2870 |
thisconnect
requested changes
Sep 9, 2024
| private toggleCoinControl = () => { | ||
| this.setState(({ activeCoinControl }) => { | ||
| if (activeCoinControl) { | ||
| this.selectedUTXOs = {}; |
There was a problem hiding this comment.
note for myself: I was quickly confused why this is gone, but it looks like toggleCoinControl was only used to open the dialog and activeCoinControl never true.
| @@ -601,7 +564,7 @@ class Send extends Component<Props, State> { | |||
| {t('send.button')} | |||
| </Button> | |||
| <BackButton | |||
| disabled={activeCoinControl || activeScanQR} | |||
| disabled={activeScanQR} | |||
NicolaLS
force-pushed
the
coin-control-sub-component
branch
from
ff0dfd4
to
e389681
Compare
Create a sub-component for the coin control toggle and dialog (utxo selection) to make the send.tsx component smaller and easier to understand. We can remove `activeCoinControl` from the back button disable property because a) the use can already navigate back using ESC, and b) the back button is not clickable while there is an active overlay.
NicolaLS
force-pushed
the
coin-control-sub-component
branch
from
e389681
to
d1a2916
Compare
|
@thisconnect thanks! (first push is rebase, second addressed the change requests). PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After: #2870 and #2866
Create a sub-component for the coin control (toggle and utxo selection dialog) to make the
send.tsxcomponent smaller and easier to understand.