frontend: don't disable back-button in send #2870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't disable the back button in send.tsx when a dialog/modal (QR scanner, or UTXO selection) is open. It is a UX best practice to do this when a modal is open **however** a) our dialog CSS creates an overlay which means nothing behind it can be clicked anyways, and b) the back button currently supports ESC which should close the modal but navigates back from the send route right now. If we don't need the is-open state for these modals we can simplify the send component in another refactor by extracting coin control into its own sub-component (moving `activeCoinControl` there) and moving `activeScanQR` into `ReceiverAddressInput`.
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't disable the back button in send.tsx when a dialog/modal (QR scanner, or UTXO selection) is open. It is a UX best practice to do this when a modal is open however a) our dialog CSS creates an overlay which means nothing behind it can be clicked anyways, and b) the back button currently supports ESC which should close the modal but navigates back from the send route right now.
If we don't need the is-open state for these modals we can simplify the send component in another refactor by extracting coin control into its own sub-component (moving
activeCoinControlthere) and movingactiveScanQRintoReceiverAddressInput.This PR does not change anything because the back-button is not clickable because of the screen size (100%) overlay used:
bitbox-wallet-app/frontends/web/src/components/dialog/dialog.module.css
Lines 9 to 12 in bdf270c