frontend: move activeScanQR into ReceiverAddressInput sub-component
#2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolaLS
changed the title
activeScanQR into ReceiverAddressInput sub-component
NicolaLS
force-pushed
the
move-active-scan-qr-in-receiver-address-input
branch
from
5c240d6
to
adf548c
Compare
|
rebased / also amended the commit message to explain the change from #2870 |
NicolaLS
force-pushed
the
move-active-scan-qr-in-receiver-address-input
branch
2 times, most recently
from
a20ddcc
to
53627c2
Compare
NicolaLS
commented
Sep 9, 2024
frontends/web/src/routes/account/send/components/inputs/receiver-address-input.tsx
Show resolved
Hide resolved
frontends/web/src/routes/account/send/components/inputs/receiver-address-input.tsx
Show resolved
Hide resolved
NicolaLS
force-pushed
the
move-active-scan-qr-in-receiver-address-input
branch
from
53627c2
to
b0d5cfc
Compare
Move the `activeScanQR` state used to control the QR scanner dialog (open/closed) into the `ReceiverAddressInput` to simplify the component. We can remove the `activeScanQR` from the back button disabled property because a) navigation with ESC allows the user to go back anyways and b) the back button itself is not clickable when there is an active overlay.
NicolaLS
force-pushed
the
move-active-scan-qr-in-receiver-address-input
branch
from
b0d5cfc
to
75a7808
Compare
|
@thisconnect tested webdev and anroid, CI lint fail is unrelated could you please run CI again ? |
|
@NicolaLS CI passed 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2870
In case #2870 is merged we can remove a lot of complexity from the open/closed state management of the scan QR dialog.