Use dict_factory in store for better readability #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouni
force-pushed
the
store-dict-factory
branch
from
688a4e9 to
25d27f1
Compare
chmorgan
reviewed
Jul 28, 2024
| @@ -779,7 +779,7 @@ def toggle_bom_pos(self, *_): | |||
| fp = board.FindFootprintByReference(ref) | |||
| bom = toggle_exclude_from_bom(fp) | |||
| pos = toggle_exclude_from_pos(fp) | |||
| self.store.set_bom(ref, bom) | |||
| self.store.set_bom(ref, int(bom)) | |||
There was a problem hiding this comment.
what was up with the necessity to cast here but not previously? (No mention in the commit message of the reason why)
There was a problem hiding this comment.
I don't remember but I guess that sqlite doesn't like to get a "1" for a boolean value. Previously the casting was done in th e set_bom function, in other places it was done like this. So I decided to make the cast always in the same place.
Bouni
force-pushed
the
store-dict-factory
branch
from
b904539 to
cd001af
Compare
chmorgan
approved these changes
Jul 30, 2024
|
Thanks @chmorgan for the review 👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always struggled with al those index numbers scatterd all around the code base and for a long time wanted to improve that.
So I started with the store and introduced a row_factory that returns a dict instead of a list which improves readability throughout the code base a lot.
For example
if self.hide_bom_parts and part[6]:becomes
if self.hide_bom_parts and part["exclude_from_bom"]: