-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dict_factory in store for better readability #487
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
248c5e5
Add dict_factory helper
Bouni ab4813c
Let read_all return a dict instead of a list
Bouni 76dcc11
Use dict in populate_footprint_list for better readability
Bouni 1d82f69
Improve get_part to use dict_factory for better readability
Bouni 8f373d4
Use dict instead of list in update_part
Bouni e39bdab
Improve readability even more
Bouni ebc624a
Imporved readability by using named style query
Bouni 72dbeef
Improved context manager of read_all
Bouni 0df9fb0
Use named style in create_part for better readability
Bouni 20a9f41
Add type hints
Bouni 78e4d96
Remove unused methods
Bouni 0dbfa84
Remove one more unused method
Bouni 8cb2834
Use named style in get_part
Bouni a902d0e
Use named style in set_stock
Bouni 99125b1
Use named style in set_bom
Bouni 1fddc87
Use named style in set_pos
Bouni 374c562
Use named style in set_lcsc
Bouni d64bd23
Remove debugging message
Bouni 06b59d0
Use dict in generate_cpl
Bouni 0861e85
Restore method, make use of dict_factory
Bouni b20b825
use dict in generate_bom
Bouni e409c16
Fix merge fuckup
Bouni cd001af
Remove debug message
Bouni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was up with the necessity to cast here but not previously? (No mention in the commit message of the reason why)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember but I guess that sqlite doesn't like to get a "1" for a boolean value. Previously the casting was done in th e set_bom function, in other places it was done like this. So I decided to make the cast always in the same place.