Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none: some tiny code tidy-up #34

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

Shane-XB-Qian
Copy link
Contributor

No description provided.

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
@Breeze0806
Copy link
Owner

Breeze0806 commented Apr 10, 2024

Thank you so much for your PR! It's truly helpful, especially for replacing the deprecated ioutil package with the fs package in the code. If you could kindly merge this PR with #35, I would greatly appreciate it.

@Shane-XB-Qian
Copy link
Contributor Author

If you could kindly merge this PR with #35

#35 is for db2 dev env, actually to me, it maybe more useful.
as for this one, i may push similar PR like this one later, i may look into this code base more, later.

@Breeze0806 Breeze0806 merged commit 4f62855 into Breeze0806:main Jun 1, 2024
6 checks passed
@Shane-XB-Qian Shane-XB-Qian deleted the none_some_code_tidyup branch June 2, 2024 10:54
Breeze0806 added a commit that referenced this pull request Jul 21, 2024
* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat & fix & docs: Add column name to error message when there's an error in reading or writing a column, fix the issue where ignoreOneByOneError does not work when set to false, and add F&Q for the database reader and writer. (#38)

* none: some tiny code tidy-up (#34)

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* docs: Update README.md

* feat & docs: improve go1.16 to go 1.20, change package sqlserver to github.com/microsoft/go-mssqldb,and Update all packages to the latest version.

* fix: fix some complime error

* fix:fix complie error

* scripts: do lint for all go version

* fix: 修复mysql的问题

* docs: fix go version

* feat: in package element add NewBigIntColumnValueFromUint64 and NewDecimalColumnValueFromFloat32, remove Float64 and add Uint64.

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>
limawanyan added a commit that referenced this pull request Sep 28, 2024
* feat:  add database sqlite3 reader/writer

* sqlite3: reset (#43)

* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat & fix & docs: Add column name to error message when there's an error in reading or writing a column, fix the issue where ignoreOneByOneError does not work when set to false, and add F&Q for the database reader and writer. (#38)

* none: some tiny code tidy-up (#34)

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* docs: Update README.md

* feat & docs: improve go1.16 to go 1.20, change package sqlserver to github.com/microsoft/go-mssqldb,and Update all packages to the latest version.

* fix: fix some complime error

* fix:fix complie error

* scripts: do lint for all go version

* fix: 修复mysql的问题

* docs: fix go version

* feat: in package element add NewBigIntColumnValueFromUint64 and NewDecimalColumnValueFromFloat32, remove Float64 and add Uint64.

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>

* feat: add sqlite3 data read

* add Sqlite3 (#52)

* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat:add sqlite3

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: Breeze0806 <53822089+Breeze0806@users.noreply.github.com>

* fix: 修复sqlite3测试的问题

* fix: fit go1.20

* fix: makefile

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>
limawanyan added a commit that referenced this pull request Oct 8, 2024
…y in sql server (#54)

* add Sqlite3 to v0.2.x (#53)

* feat:  add database sqlite3 reader/writer

* sqlite3: reset (#43)

* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat & fix & docs: Add column name to error message when there's an error in reading or writing a column, fix the issue where ignoreOneByOneError does not work when set to false, and add F&Q for the database reader and writer. (#38)

* none: some tiny code tidy-up (#34)

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* docs: Update README.md

* feat & docs: improve go1.16 to go 1.20, change package sqlserver to github.com/microsoft/go-mssqldb,and Update all packages to the latest version.

* fix: fix some complime error

* fix:fix complie error

* scripts: do lint for all go version

* fix: 修复mysql的问题

* docs: fix go version

* feat: in package element add NewBigIntColumnValueFromUint64 and NewDecimalColumnValueFromFloat32, remove Float64 and add Uint64.

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>

* feat: add sqlite3 data read

* add Sqlite3 (#52)

* none: some env tidy up (#35)

1. Makefile: local may have 'DB2_HOME' already
2. .gitignore: adding ignores for vim and tags

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>

* fix: fix split bug when setting is not set (#37)

* feat:add sqlite3

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: Breeze0806 <53822089+Breeze0806@users.noreply.github.com>

* fix: 修复sqlite3测试问题

* fix: fit go1.20

* fix: makefile

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>

* docs & test: add sqlite3 unit test , fix the issue of readme document

* fix: fix check error

* docs: add docment of bulk copy(BULK INSERT)

* build: upgrade mod file

* docs: fix some errors in config file and document

---------

Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
Co-authored-by: Shane-XB-Qian <shane.qian@live.com>
Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants