fix: fix split bug when setting is not set #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 92.39% 92.35% -0.04%
==========================================
Files 124 124
Lines 6678 6684 +6
==========================================
+ Hits 6170 6173 +3
- Misses 404 406 +2
- Partials 104 105 +1 ☔ View full report in Codecov by Sentry. |
Breeze0806
added a commit
that referenced
this pull request
Jul 21, 2024
* none: some env tidy up (#35) 1. Makefile: local may have 'DB2_HOME' already 2. .gitignore: adding ignores for vim and tags Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> * fix: fix split bug when setting is not set (#37) * feat & fix & docs: Add column name to error message when there's an error in reading or writing a column, fix the issue where ignoreOneByOneError does not work when set to false, and add F&Q for the database reader and writer. (#38) * none: some tiny code tidy-up (#34) Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> * docs: Update README.md * feat & docs: improve go1.16 to go 1.20, change package sqlserver to github.com/microsoft/go-mssqldb,and Update all packages to the latest version. * fix: fix some complime error * fix：fix complie error * scripts: do lint for all go version * fix: 修复mysql的问题 * docs: fix go version * feat: in package element add NewBigIntColumnValueFromUint64 and NewDecimalColumnValueFromFloat32, remove Float64 and add Uint64. --------- Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Co-authored-by: Shane-XB-Qian <shane.qian@live.com> Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>
Breeze0806
added a commit
that referenced
this pull request
Sep 28, 2024
* none: some env tidy up (#35) 1. Makefile: local may have 'DB2_HOME' already 2. .gitignore: adding ignores for vim and tags Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> * fix: fix split bug when setting is not set (#37) * feat:add sqlite3 * feat:add sqlite3 * feat:add sqlite3 * feat:sqlite3 * feat:improve sqlite3 * feat:sqlite3 * feat:add sqlite3 test * feat:sqlite3 * feat:add sqlite3 test * feat:add sqlite3 test --------- Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Co-authored-by: Shane-XB-Qian <shane.qian@live.com> Co-authored-by: Breeze0806 <53822089+Breeze0806@users.noreply.github.com>
limawanyan
added a commit
that referenced
this pull request
Sep 28, 2024
* feat: add database sqlite3 reader/writer * sqlite3: reset (#43) * none: some env tidy up (#35) 1. Makefile: local may have 'DB2_HOME' already 2. .gitignore: adding ignores for vim and tags Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> * fix: fix split bug when setting is not set (#37) * feat & fix & docs: Add column name to error message when there's an error in reading or writing a column, fix the issue where ignoreOneByOneError does not work when set to false, and add F&Q for the database reader and writer. (#38) * none: some tiny code tidy-up (#34) Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> * docs: Update README.md * feat & docs: improve go1.16 to go 1.20, change package sqlserver to github.com/microsoft/go-mssqldb,and Update all packages to the latest version. * fix: fix some complime error * fix：fix complie error * scripts: do lint for all go version * fix: 修复mysql的问题 * docs: fix go version * feat: in package element add NewBigIntColumnValueFromUint64 and NewDecimalColumnValueFromFloat32, remove Float64 and add Uint64. --------- Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Co-authored-by: Shane-XB-Qian <shane.qian@live.com> Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com> * feat: add sqlite3 data read * add Sqlite3 (#52) * none: some env tidy up (#35) 1. Makefile: local may have 'DB2_HOME' already 2. .gitignore: adding ignores for vim and tags Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> * fix: fix split bug when setting is not set (#37) * feat:add sqlite3 --------- Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Co-authored-by: Shane-XB-Qian <shane.qian@live.com> Co-authored-by: Breeze0806 <53822089+Breeze0806@users.noreply.github.com> * fix： 修复sqlite3测试的问题 * fix: fit go1.20 * fix: makefile --------- Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Co-authored-by: Shane-XB-Qian <shane.qian@live.com> Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>
limawanyan
added a commit
that referenced
this pull request
Oct 8, 2024
…y in sql server (#54) * add Sqlite3 to v0.2.x (#53) * feat: add database sqlite3 reader/writer * sqlite3: reset (#43) * none: some env tidy up (#35) 1. Makefile: local may have 'DB2_HOME' already 2. .gitignore: adding ignores for vim and tags Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> * fix: fix split bug when setting is not set (#37) * feat & fix & docs: Add column name to error message when there's an error in reading or writing a column, fix the issue where ignoreOneByOneError does not work when set to false, and add F&Q for the database reader and writer. (#38) * none: some tiny code tidy-up (#34) Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> * docs: Update README.md * feat & docs: improve go1.16 to go 1.20, change package sqlserver to github.com/microsoft/go-mssqldb,and Update all packages to the latest version. * fix: fix some complime error * fix：fix complie error * scripts: do lint for all go version * fix: 修复mysql的问题 * docs: fix go version * feat: in package element add NewBigIntColumnValueFromUint64 and NewDecimalColumnValueFromFloat32, remove Float64 and add Uint64. --------- Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Co-authored-by: Shane-XB-Qian <shane.qian@live.com> Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com> * feat: add sqlite3 data read * add Sqlite3 (#52) * none: some env tidy up (#35) 1. Makefile: local may have 'DB2_HOME' already 2. .gitignore: adding ignores for vim and tags Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> * fix: fix split bug when setting is not set (#37) * feat:add sqlite3 --------- Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Co-authored-by: Shane-XB-Qian <shane.qian@live.com> Co-authored-by: Breeze0806 <53822089+Breeze0806@users.noreply.github.com> * fix： 修复sqlite3测试问题 * fix: fit go1.20 * fix: makefile --------- Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Co-authored-by: Shane-XB-Qian <shane.qian@live.com> Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com> * docs & test: add sqlite3 unit test , fix the issue of readme document * fix: fix check error * docs: add docment of bulk copy(BULK INSERT) * build: upgrade mod file * docs: fix some errors in config file and document --------- Signed-off-by: shane.xb.qian <shane.qian@foxmail.com> Co-authored-by: Shane-XB-Qian <shane.qian@live.com> Co-authored-by: 励码万言 <48382427+limawanyan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36