-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sp_BlitzLock Incorrect databasename for Check ID 9 if the database has a dot in the name #2452
Comments
Don't really know how to fix this, the real problem exists in the Deadlock XML report: You could replace: That fixes the database name. |
…es_with_odd_names #2452 sp_BlitzLock object names with periods
Yeah, I'd rather not do a halfway fix. If you come up with an all-the-way fix that works for all kinds of object names, definitely give that a shot, but for now I've added it to the documentation as a known issue, and closing it. |
Agreed. |
It can be done with the associatedObjectId attribute in the same keylock element of the report and a subquery:
But that's a big change. |
@BrentOzar Could you reconsider re-opening this one? |
Yeah, absolutely! Sorry about the delay on that - I saw the pull request on my phone and I made a mental note to come back here and reopen it, and it slipped my mind. Thanks for the reminder! I haven't looked at the code yet, but will in the next round of tests that I do. Thanks for the pull request! |
No problem! |
Looks good! I merged it into the dev branch, and it'll be in the August release with credit to you in the release notes. Thanks for solving this - I know it couldn't have been an easy problem. At least it wasn't for me, ha ha ho ho. |
Version of the script
2.96
2020-06-06 00:00:00.000
What is the current behavior?
If the database name has a DOT in the name eg [Data.Base], only the last part of the name is returned in the database_name.
If the current behavior is a bug, please provide the steps to reproduce.
On [Data.Base] with Deadlock data, run:
EXEC [dbo].sp_BlitzLock @databasename='Data.Base'
result:
What is the expected behavior?
I expect the full database name.
Which versions of SQL Server and which OS are affected by this issue? Did this work in previous versions of our procedures?
Tested on 14.0.1000.169
The text was updated successfully, but these errors were encountered: