Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2452 Fixes sp_BlitzLock object names with periods #2459

Merged
merged 3 commits into from
Jul 18, 2020
Merged

2452 Fixes sp_BlitzLock object names with periods #2459

merged 3 commits into from
Jul 18, 2020

Conversation

defcon84
Copy link
Contributor

@defcon84 defcon84 commented Jul 4, 2020

Closes #2452.

@BrentOzar BrentOzar added this to the 2020-08 Release milestone Jul 10, 2020
@BrentOzar BrentOzar self-requested a review July 10, 2020 10:23
BrentOzar
BrentOzar reviewed Jul 12, 2020
View reviewed changes
sp_BlitzLock.sql Outdated Show resolved Hide resolved
@BrentOzar BrentOzar removed this from the 2020-08 Release milestone Jul 12, 2020
@defcon84
Copy link
Contributor Author

@BrentOzar Sounds the right thing to do, I have changed it.

BrentOzar
BrentOzar approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@BrentOzar BrentOzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only did a cursory look at the code, and I didn't check to see whether it works on case sensitive servers, but I did test it on 2019 with databases & tables with periods in the name, and it works.

@BrentOzar BrentOzar merged commit 6a6216e into BrentOzarULTD:dev Jul 18, 2020
@defcon84 defcon84 deleted the 2452_sp_BlitzLock_object_names_with_periods_fix branch July 21, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrentOzar BrentOzar BrentOzar approved these changes

Assignees

@defcon84 defcon84

Labels
bug sp_BlitzLock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sp_BlitzLock Incorrect databasename for Check ID 9 if the database has a dot in the name
2 participants
@defcon84 @BrentOzar