-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case insensitive matching of unit names (mL vs ml etc) #725
Comments
Yes, that's a good idea. I wouldn't remember it was mL either! Maybe it will suffice to do case-insensitive matching. I'll have a look. |
Looks like the fix isn't too bad, but I need to make it in two different places, which is annoying me. I'll either try to fix that duplication or comment why it's hard to do so! 😃 |
matty0ung
pushed a commit
to matty0ung/brewken
that referenced
this issue
Mar 7, 2023
matty0ung
changed the title
mL vs ml
Case insensitive matching of unit names (mL vs ml etc)
Mar 8, 2023
This was referenced Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I know the proper notation is mL. But could we maybe stretch the definitions a little and make 'ml' an equivalent? I keep forgetting and the volume entries will default to L when they don't recognize the unit. The difference between 3 mL of lactic acid and 3 L is significant and somewhat surprising.
The text was updated successfully, but these errors were encountered: