Add case insensitive matching for unit names + Mac packaging fixes #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matty0ung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #725
Also a bit more work on the Mac build/packaging trying to fix this library-not-found-even-though-it's-there issue. (Including realised the final step of the Mac packaging was creating an empty .dmg file, which this fixes.)
Also tidied up a few comments.
(I meant this to be two separate PRs, but did things in the wrong order on github.)
NB: I think the changes I've done on looking up unit names slightly change the behaviour when you enter an ambiguous unit name. Eg, if you type '5 gal', there is sometimes no way for us to know whether you mean US gallons or Imperial gallons - eg because you are using the free-standing conversion tool or you have configured a field's default units to be metric. At the moment, if there are no other clues to follow, you get whichever type of gallon the program happens to find first, which might be different than in previous versions of the software. I don't use gallons (of either sort) myself, so, if anyone who does wants to tell me how the behaviour should be different, then I would be very happy to hear it.