util: use average bias while grouping arrays

This makes sure that strongly deviating entry length are taken into account while grouping arrays. PR-URL: nodejs#28070 Refs: nodejs#27690 Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR · Jun 17, 2019 · b97b003 · b97b003
1 parent 87a22cf
commit b97b003
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -997,7 +997,8 @@ function groupArrayElements(ctx, output, value) {
       (totalLength / actualMax > 5 || maxLength <= 6)) {
 
     const approxCharHeights = 2.5;
-    const biasedMax = Math.max(actualMax - 4, 1);
+    const averageBias = Math.sqrt(actualMax - totalLength / output.length);
+    const biasedMax = Math.max(actualMax - 3 - averageBias, 1);
     // Dynamically check how many columns seem possible.
     const columns = Math.min(
       // Ideally a square should be drawn. We expect a character to be about 2.5

diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
@@ -2274,14 +2274,12 @@ assert.strictEqual(
 
   expected = [
     '[',
-    '  1, 1,         1,',
-    '  1, 1,         1,',
-    '  1, 1,         1,',
-    '  1, 1,         1,',
-    '  1, 1,         1,',
-    '  1, 1,         1,',
-    '  1, 1,         1,',
-    '  1, 1,         1,',
+    '  1, 1,         1, 1,',
+    '  1, 1,         1, 1,',
+    '  1, 1,         1, 1,',
+    '  1, 1,         1, 1,',
+    '  1, 1,         1, 1,',
+    '  1, 1,         1, 1,',
     '  1, 1, 123456789',
     ']'
   ].join('\n');