Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakey > tag-list > vdiff > query dom for child removal instead of height change #5264

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KearseTrevor
Copy link
Contributor

@KearseTrevor KearseTrevor commented Dec 20, 2024

Was getting sporadic flakes both locally and remote during CI for 'Element did not reach expected height' so swapping it to checking for removal of tag-list-items.

Context: #5258

https://desire2learn.atlassian.net/browse/GAUD-7368

@KearseTrevor KearseTrevor requested a review from a team as a code owner December 20, 2024 15:54
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-5264/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

KearseTrevor and others added 2 commits December 20, 2024 13:33
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant