Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flakey > tag-list > vdiff > query dom for child removal instead of height change #5264

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

flakey > tag-list > vdiff > query dom for child removal instead of height change #5264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48b1cab
swap waitUntil to query dom for child removal instead of height
KearseTrevor Dec 20, 2024
e701c8a
Merge branch 'main' into tag-list-clear-all-vdiff-waitUntil-fix
KearseTrevor Dec 20, 2024
9c81b23
Updating vdiff goldens (#5265)
github-actions[bot] Dec 20, 2024
cc1de07
Merge branch 'main' into tag-list-clear-all-vdiff-waitUntil-fix
KearseTrevor Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...s/tag-list/test/golden/tag-list/chromium/clearable-behavior-click-clear-all.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 5 additions & 2 deletions components/tag-list/test/tag-list.vdiff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,11 @@ describe('tag-list', () => {
});

it('click clear all', async() => {
await clickElem(elem.shadowRoot.querySelector('d2l-button-subtle.d2l-tag-list-clear-button'));
await waitUntil(() => elem.clientHeight === 30, 'Element did not reach expected height', { timeout: 2000 });
const button = elem.shadowRoot.querySelector('d2l-button-subtle.d2l-tag-list-clear-button');
await clickElem(button);
await elem.updateComplete;

await waitUntil(() => elem.querySelector('d2l-tag-list-item, d2l-tag-list-item-mixin-consumer') === null, 'Element did not remove children', { timeout: 2000 });
await expect(elem).to.be.golden();
});
});
Expand Down
Loading