Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Update music module #1024

Open
dedmen opened this issue Nov 15, 2018 · 0 comments
Open

Task: Update music module #1024

dedmen opened this issue Nov 15, 2018 · 0 comments
Labels
Cleanup
Milestone
Backlog

Comments

@dedmen
Copy link
Contributor

dedmen commented Nov 15, 2018 •
edited
Loading

CBA Version: 3.9.0 (stable)

Description:
CBA Music module isn't really useful in it's current implementation

https://github.com/CBATeam/CBA_A3/blob/master/addons/music/fnc_isMusicPlaying.sqf just does a isNil check, but nothing set's that variable to nil if the music stopped. Unless you call CBA_fnc_getMusicPlaying before, and even that only detects if the remaining time ran out, not if the music has been stopped by something else.
It should be using the MusicStopped EH https://community.bistudio.com/wiki/addMusicEventHandler.

I got the Idea through this thread: https://armaworld.de/index.php?thread/4165-musik-als-dauerschleife-%C3%BCber-description-ext/&postID=33251#post33251

Also there are tons of unquoted strings in the tags of CfgMusic.hpp, armake will complain about that.

Priority of this is very Minor I'd say. I haven't seen anyone use the music module yet
@commy2 commy2 added this to the Backlog milestone Feb 8, 2019
@commy2 commy2 added the Cleanup label Feb 8, 2019
@R3voA3 R3voA3 mentioned this issue Jul 29, 2019
Merged
Eathox added a commit to Eathox/CBA_A3 that referenced this issue Mar 29, 2020
@Eathox
Fix for CBA_fnc_isMusicPlaying not handling music stop properly
df17e5c 
(mentioned in: CBATeam#1024)
@Eathox Eathox mentioned this issue Mar 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@dedmen @commy2