Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put tags in CfgMusic.hpp into quotes #1192

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Put tags in CfgMusic.hpp into quotes #1192

merged 3 commits into from
Sep 9, 2019

Conversation

R3voA3
Copy link
Contributor

@R3voA3 R3voA3 commented Jul 29, 2019

Put tags in CfgMusic.hpp into quotes

Was suggested by @dedmen in #1024

@R3voA3
Put tags into quotes
1298d71 
Put tags into quotes
@R3voA3 R3voA3 changed the title Put tags into quotes Put tags in CfgMusic.hpp into quotes Jul 29, 2019
@commy2
Copy link
Contributor

commy2 commented Jul 29, 2019

  • Opening curly brackets should be at EOL not a new line just for them.
  • What is the point of this file anyway? Are these not all base game classes?
  • theme entry is just copy pasted from the base game config?

dedmen
dedmen approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did what?

2018

Oh. Ok.

@dedmen
Copy link
Contributor

dedmen commented Jul 29, 2019 •
edited
Loading

What is the point of this file anyway? Are these not all base game classes?

Yes but I think we are just adding tags to the new music stuff thingy?
When I looked at the music PR this stuff made sense I guess.

#598 @fishykins

@R3voA3
Removed double quotes from some theme entries.
7213615 
Removed double quotes from some theme entries.
@dedmen
Copy link
Contributor

dedmen commented Jul 30, 2019

Removed double quotes from some theme entries.

Well as you can see you clearly can't trust my reviews 🥇

commy2
commy2 suggested changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening curly brackets should be at EOL not a new line just for them.

@R3voA3
Opening brackes are now EOL
f46e92b 
- Opening brackes are now EOL
@R3voA3
Copy link
Contributor Author

R3voA3 commented Jul 30, 2019

There are a few tracks missing. Should I add them aswell?

@commy2 commy2 added this to the 3.12.2 milestone Sep 9, 2019
@commy2 commy2 added the Cleanup label Sep 9, 2019
@commy2 commy2 merged commit 8274a56 into CBATeam:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedmen dedmen dedmen approved these changes

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
3.12.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@R3voA3 @commy2 @dedmen