Add french translations for CBA UI #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
reviewed
Oct 4, 2018
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Make sure this doesn't readd the BOM removed in #1000
There was a problem hiding this comment.
i've used tabler 0.8.0, which shouldn't.
There was a problem hiding this comment.
good question, no idea, maybe @bux can help?
There was a problem hiding this comment.
just checked, no BOM.
There was a problem hiding this comment.
However @alganthe changed the encoding from BOM to nonBOM in the strings stringtable which @veteran29 forgot
commy2
reviewed
Oct 4, 2018
Note: the thousand separator in french is indeed a space.
ViperMaul
added a commit
that referenced
this pull request
Oct 10, 2018
* master: Add Turkish translations (#1002) Add french translations for CBA UI (#1001) JAM STANAG and 7.62.x51 (#997) Remove BOM character from stringtables (#1000) More JAM stuff (#995) minor last-minute tweaks for AK magwells (#994) add CBA_762x39_RPK Translate JAM and JR module nams into Polish (#987) add magwells for current IFA3, FOW, LEN weapons Split/extend the magwell classes by size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: