Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BOM character from stringtables #1000

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Conversation

veteran29
Copy link
Member

When merged this pull request will:

  • Remove BOM character from stringtable files

This repo .editorconfig is configured to encode files in UTF-8 without BOM, however currently most of the stringtables are encoded in UTF-8 with BOM character. From my tests it looks like it is due to usage of Tabler.

Even when files are encoded without BOM the Tabler will save them with it.

@dedmen
Copy link
Contributor

dedmen commented Oct 3, 2018

Even when files are encoded without BOM the Tabler will save them with it.

Did you open a bug report for tabler?

@veteran29
Copy link
Member Author

Yup.

bux/tabler#52

@bux
Copy link
Contributor

bux commented Oct 4, 2018

https://github.com/bux/tabler/releases/tag/v0.8.0

@commy2 commy2 added the Cleanup label Oct 4, 2018
@commy2 commy2 added this to the 3.9 milestone Oct 4, 2018
@commy2 commy2 merged commit d846dec into CBATeam:master Oct 4, 2018
ViperMaul added a commit that referenced this pull request Oct 10, 2018
* master:
  Add Turkish translations (#1002)
  Add french translations for CBA UI (#1001)
  JAM STANAG and 7.62.x51 (#997)
  Remove BOM character from stringtables (#1000)
  More JAM stuff (#995)
  minor last-minute tweaks for AK magwells (#994)
  add CBA_762x39_RPK
  Translate JAM and JR module nams into Polish (#987)
  add magwells for current IFA3, FOW, LEN weapons
  Split/extend the magwell classes by size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants