Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BOM character from stringtables #6626

Merged
merged 1 commit into from
Oct 7, 2018
Merged

Remove BOM character from stringtables #6626

merged 1 commit into from
Oct 7, 2018

Conversation

veteran29
Copy link
Member

When merged this pull request will:

  • Remove BOM character from stringtable files

This repo .editorconfig is configured to encode files in UTF-8 without BOM, however currently most of the stringtables are encoded in UTF-8 with BOM character.

See CBATeam/CBA_A3#1000

@bux bux added the ignore-changelog Release Notes: Excluded label Oct 7, 2018
@bux bux added this to the 3.13.0 milestone Oct 7, 2018
dedmen
dedmen approved these changes Oct 7, 2018
View reviewed changes
Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noooo this all-modules wide change will hide my last all-modules wide change in the "last editing commit" column on github :U
But I still like it because I have to.

@commy2 commy2 merged commit 98bf92f into acemod:master Oct 7, 2018
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 9, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@commy2
Merge pull request #6626 from veteran29/remove-BOM
0086c21 
Remove BOM character from stringtables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bux bux bux approved these changes

@dedmen dedmen dedmen approved these changes

Assignees
No one assigned
Labels
ignore-changelog Release Notes: Excluded
Projects
None yet
Milestone
3.12.4
Development

Successfully merging this pull request may close these issues.
5 participants
@veteran29 @bux @dedmen @commy2 @PabstMirror