CBA_fnc_currentUnit report UAV entity when controlling UAV

[commy2]

When merged this pull request will:

• close Visionmode EH issue with drone, selecting night vision. #1004

This is more complex than the original, and this is a function called every frame in ACE.

Thoughts?

[PabstMirror]

This will have massive effects in ace because ace_player will be the uav robot
typeOf ace_player = "B_UAV_AI"
interaction menu, stamina, hearing... will all have problems with this
(e.g. can self interact and check the robot's pulse)

[PabstMirror]

Maybe use ace's uav eh https://github.com/acemod/ACE3/blob/master/addons/common/XEH_postInit.sqf#L285-L327

and then we could set cba_controledUnit on either player change or uav change events
there would be no polling overhead
and addPlayeEH would check _data = currentVisionMode cba_controledUnit;

[commy2]

Hmm, one alternative would be to only use the UAV entity to read the visionMode, and keep currentUnit the way it is. Then one could additionally add an event whenever the controlledUnit changes.

[commy2]

I'm a bit hesitant to use PlayerViewChanged, because that worked out so bad the last time.

[dedmen]

Is there any practical reason why we need this?
Ignoring that it breaks like... Most mods that use this?
TFAR/ACRE your radio will suddenly not work when you are controlling a UAV because the UAV doesn't have a Radio and your hearing/voice will suddenly be inside the UAV.
Don't know what ACE would do but I guess even worse.

Opposed to Zeus Remote Control. You aren't actually really inside the drone when you're controlling it. You are controlling it via a little tablet in your hand.

[commy2]

True. The only reason one would the need the UAV entity is to read the night vision mode from. I'll change the PR to do that instead.

[commy2]

What about this?

[dedmen]

Is this change still necessary? I mean.. I like the performance gain..

[commy2]

I did it just to compensate for the loss due to this.

[commy2]

Is it good?

[dedmen]

Is the wiki page wrong?
https://community.bistudio.com/wiki/UAVControl
_data should be 2 element array. find _player should always return 0.

[commy2]

Is the wiki page wrong?

Always.

Drone with turret + driver/pilot looks like this:
[object1, "DRIVER", object2, "GUNNER"]
In MP, it can be controlled by multiple people. Therefore #0 is not necessarily the local player.

[PabstMirror]

We could optimize for common case, which would be no UAV connected

_data = UAVControl getConnectedUAV player; 
if !(_data isEqualTo oldUAVControl) then {
0.0022 ms

if (!isNull getConnectedUAV player) then { // full code runs every time connected to UAV
0.0017 ms

https://github.com/CBATeam/CBA_A3/compare/currentUnit-UAV...uavPossibleOpti?expand=1
Not sure if worth it

[commy2]

Don't think that's worth it.

Merge?