ACE nightvision edits, ffv nvg overlay fix #6635
Conversation
**When merged this pull request will:** - Changed hardcoded 0.5 NVG fog modifier for players in "air" type vehicle to CBA option (0.1 to 1.0 range). - Added CBA options for fog modifier (0.1 to 1.0 ranges) for tank crew, car crew, static weapons and when using NV-capable binoculars. - These fog modifiers are only applied when in gunner view of a NV-capable seat/turret, otherwise players still use their own NVGs. - NV-capable binoculars work from FFV seats with binocular modifier. - Fixed nvg overlay not applying when using FFV seats/ADS from FFV. - Added ADS blur when using non-NV capable static weapons, technical turrets with NV goggles. Known issues: - When coming out of binos, noticable flash at the corners of the screen before the NVG overlay is applied. Issue present in current ACE release. Wasn't able to resolve. - UAV cameras are affected by ACE_player's nightvision status. If ACE_player has nightvision on, the NVG effects are overlaid on the UAV camera. Issue present in current ACE release. - Unable to reliably detect when player controlled UAV is changing vision modes to account for UAVs. Potential bug with CBA Visionmode player EH. The EH doesn't trigger when changing from normal to night vision in when remote controlling drone. Raised issue on CBA github, CBATeam/CBA_A3#1004 First time contributing, let me know if I missed anything.
|
A PR that fixes the CBA issue: CBATeam/CBA_A3#1005 |
addons/nightvision/stringtable.xml
Outdated
| @@ -283,37 +283,62 @@ | |||
| <German>Visierunschärfe</German> | |||
| <Chinese>瞄準具模糊程度</Chinese> | |||
| <Chinesesimp>瞄准具模糊程度</Chinesesimp> | |||
| <Italian>Blur durante la mira</Italian> | |||
There was a problem hiding this comment.
Why are you removing italian translations?
There was a problem hiding this comment.
It wasn't intentional. I'm new to github, when I started work on this PR I cloned ACE instead of making a fork. The Italian translation was added between when I started and when I learned how to fork, and I used the out of date stringtable without updating it by mistake.
Italian translation should be in with the last commit.
I still need to make sure UAVs are handled correctly with commy2's fix for the CBA issue, so this still needs work.
Integrated missing Italian Translations.
|
Updated stringtable.xml with Italian translations missing from original pull request. |
|
Closing due to age and/or inactivity, unlikely to be finished or has to be reworked due to other changes over the years. May be re-opened if someone finds it useful, even better just open a new up-to-date PR. |
When merged this pull request will:
Known issues:
First time contributing, let me know if I missed anything.