-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Arma vanilla magwells #1030
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,3 @@ | |
|
||
class CBA_357_6rnds {}; // 6 loose rounds of .357 Magnum | ||
class CBA_357_5rnds {}; // 5 loose rounds of .357 Magnum | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,19 @@ | ||
class CBA_580x42_TYPE95 { // QBZ-95 Stick Mags | ||
class CBA_580x42_TYPE95 { //This is DEPRECATED! Don't use it! Use the vanilla one instead | ||
BI_mags[] = { | ||
"30Rnd_580x42_Mag_F", | ||
"30Rnd_580x42_Mag_Tracer_F" | ||
}; | ||
}; | ||
|
||
class CBA_580x42_TYPE95_XL { // QBB-95 LSW Drums | ||
class CBA_580x42_TYPE95_XL { //This is DEPRECATED! Don't use it! Use the vanilla one instead | ||
BI_drums[] = { | ||
"100Rnd_580x42_Mag_F", | ||
"100Rnd_580x42_Mag_Tracer_F" | ||
}; | ||
}; | ||
|
||
|
||
class CTAR_580x42 {}; // QBZ-95 Stick Mags | ||
|
||
class CTAR_580x42_Large {}; // QBB-95 LSW Drums | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,37 @@ | ||
class CBA_65x39_MX { | ||
class CBA_65x39_MX { //This is DEPRECATED! Don't use it! Use the vanilla one instead | ||
BI_mags[] = { | ||
"30Rnd_65x39_caseless_mag", | ||
"30Rnd_65x39_caseless_green", | ||
"30Rnd_65x39_caseless_mag_Tracer", | ||
"30Rnd_65x39_caseless_green_mag_Tracer" | ||
}; | ||
}; | ||
|
||
|
||
class MX_65x39 {}; | ||
|
||
class CBA_65x39_MX_XL { | ||
BI_mags[] = { | ||
"100Rnd_65x39_caseless_mag", | ||
"100Rnd_65x39_caseless_mag_Tracer" | ||
}; | ||
}; | ||
|
||
class CBA_65x39_Mk200 { | ||
|
||
class CBA_65x39_Mk200 { //This is DEPRECATED! Don't use it! Use the vanilla one instead | ||
BI_mags[] = { | ||
"200Rnd_65x39_cased_Box", | ||
"200Rnd_65x39_cased_Box_Tracer" | ||
}; | ||
}; | ||
|
||
class CBA_65x39_Katiba { | ||
class CBA_65x39_Katiba { //This is DEPRECATED! Don't use it! Use the vanilla one instead | ||
BI_mags[] = { | ||
"30Rnd_65x39_caseless_green", | ||
"30Rnd_65x39_caseless_green_mag_Tracer" | ||
}; | ||
}; | ||
|
||
class Mk200_65x39 {}; | ||
|
||
class Katiba_65x39 {}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no 40mm magwell in vanilla.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+= won't break if the array exists right? So it doesn't really matter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, but that's the thing, doesn't exist, same thing on the UGL_F parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually meant the opposite as what I said. So does += here break in it's current state? or is it just a minor issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last I checked this kind of array addition combined with inheritance was really finicky.
The above bits seem fine though, did a quick check and magazineWell is populated.