Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Arma vanilla magwells #1030

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion addons/jam/CfgMagazineWells.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,10 @@ class CfgMagazineWells {
class CBA_Panzerschreck {}; // Panzerschreck RPzB 54
class CBA_PIAT {}; // PIAT

class CBA_RPG7 {
class CBA_RPG7 { //This is DEPRECATED! Don't use it! Use the vanilla one instead
BI_rockets[] = {
"RPG7_F"
};
};
class RPG7 {};
};
52 changes: 26 additions & 26 deletions addons/jam/CfgWeapons.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,96 +5,96 @@ class CfgWeapons {
class Launcher_Base_F;

class mk20_base_F: Rifle_Base_F {
magazineWell[] = {"CBA_556x45_STANAG", "CBA_556x45_STANAG_L", "CBA_556x45_STANAG_XL", "CBA_556x45_STANAG_2D"};
magazineWell[] += {"CBA_556x45_STANAG", "CBA_556x45_STANAG_L", "CBA_556x45_STANAG_XL", "CBA_556x45_STANAG_2D"};
};
class SDAR_base_F: Rifle_Base_F {
magazineWell[] = {"CBA_556x45_STANAG"};
magazineWell[] += {"CBA_556x45_STANAG"};
};
class Tavor_base_F: Rifle_Base_F {
magazineWell[] = {"CBA_556x45_STANAG", "CBA_556x45_STANAG_L", "CBA_556x45_STANAG_XL", "CBA_556x45_STANAG_2D"};
magazineWell[] += {"CBA_556x45_STANAG", "CBA_556x45_STANAG_L", "CBA_556x45_STANAG_XL", "CBA_556x45_STANAG_2D"};
};
class arifle_SPAR_01_base_F : Rifle_Base_F {
magazineWell[] = {"CBA_556x45_STANAG", "CBA_556x45_STANAG_L", "CBA_556x45_STANAG_XL", "CBA_556x45_STANAG_2D", "CBA_556x45_STANAG_2D_XL"};
magazineWell[] += {"CBA_556x45_STANAG", "CBA_556x45_STANAG_L", "CBA_556x45_STANAG_XL", "CBA_556x45_STANAG_2D", "CBA_556x45_STANAG_2D_XL"};
};
class arifle_SPAR_02_base_F : Rifle_Base_F {
magazineWell[] = {"CBA_556x45_STANAG", "CBA_556x45_STANAG_L", "CBA_556x45_STANAG_XL", "CBA_556x45_STANAG_2D", "CBA_556x45_STANAG_2D_XL"};
magazineWell[] += {"CBA_556x45_STANAG", "CBA_556x45_STANAG_L", "CBA_556x45_STANAG_XL", "CBA_556x45_STANAG_2D", "CBA_556x45_STANAG_2D_XL"};
};

class UGL_F : GrenadeLauncher {
magazineWell[] = {"CBA_40mm_M203", "CBA_40mm_EGLM"};
magazineWell[] += {"CBA_40mm_M203", "CBA_40mm_EGLM"};
};

class arifle_MX_Base_F : Rifle_Base_F {
magazineWell[] = {"CBA_65x39_MX", "CBA_65x39_MX_XL"};
magazineWell[] += {"CBA_65x39_MX", "CBA_65x39_MX_XL"};
class GL_3GL_F : UGL_F {
magazineWell[] = {"CBA_40mm_3GL", "CBA_40mm_M203", "CBA_40mm_EGLM"};
magazineWell[] += {"CBA_40mm_3GL", "CBA_40mm_M203", "CBA_40mm_EGLM"};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no 40mm magwell in vanilla.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+= won't break if the array exists right? So it doesn't really matter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, but that's the thing, doesn't exist, same thing on the UGL_F parent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually meant the opposite as what I said. So does += here break in it's current state? or is it just a minor issue?

Copy link
Contributor

@robalo robalo Dec 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last I checked this kind of array addition combined with inheritance was really finicky.
The above bits seem fine though, did a quick check and magazineWell is populated.

};
};

class arifle_Katiba_Base_F : Rifle_Base_F {
magazineWell[] = {"CBA_65x39_Katiba"};
magazineWell[] += {"CBA_65x39_Katiba"};
};

class arifle_ARX_base_F : Rifle_Base_F {
magazineWell[] = {"CBA_65x39_Katiba"};
magazineWell[] += {"CBA_65x39_Katiba"};
};

class EBR_base_F: Rifle_Long_Base_F {
magazineWell[] = {"CBA_762x51_M14"};
magazineWell[] += {"CBA_762x51_M14"};
};
class DMR_03_base_F: Rifle_Long_Base_F {
magazineWell[] = {"CBA_762x51_MkI_EMR"};
magazineWell[] += {"CBA_762x51_MkI_EMR"};
};
class DMR_06_base_F: Rifle_Long_Base_F {
magazineWell[] = {"CBA_762x51_M14"};
magazineWell[] += {"CBA_762x51_M14"};
};
class arifle_SPAR_03_base_F : Rifle_Base_F {
magazineWell[] = {"CBA_762x51_HK417", "CBA_762x51_HK417_L", "CBA_762x51_HK417_XL"};
magazineWell[] += {"CBA_762x51_HK417", "CBA_762x51_HK417_L", "CBA_762x51_HK417_XL"};
};

class DMR_01_base_F : Rifle_Long_Base_F {
magazineWell[] = {"CBA_762x54R_SVD"};
magazineWell[] += {"CBA_762x54R_SVD"};
};

class arifle_CTAR_base_F : Rifle_Base_F {
magazineWell[] = {"CBA_580x42_TYPE95", "CBA_580x42_TYPE95_XL"};
magazineWell[] += {"CBA_580x42_TYPE95", "CBA_580x42_TYPE95_XL"};
};
class arifle_CTARS_base_F : Rifle_Base_F {
magazineWell[] = {"CBA_580x42_TYPE95", "CBA_580x42_TYPE95_XL"};
magazineWell[] += {"CBA_580x42_TYPE95", "CBA_580x42_TYPE95_XL"};
};

class arifle_AK12_base_F : Rifle_Base_F {
magazineWell[] = {"CBA_762x39_AK", "CBA_762x39_RPK"};
magazineWell[] += {"CBA_762x39_AK", "CBA_762x39_RPK"};
};
class arifle_AKM_base_F : Rifle_Base_F {
magazineWell[] = {"CBA_762x39_AK", "CBA_762x39_RPK"};
magazineWell[] += {"CBA_762x39_AK", "CBA_762x39_RPK"};
};

class arifle_AKS_base_F : Rifle_Base_F {
magazineWell[] = {"CBA_545x39_AK", "CBA_545x39_RPK"};
magazineWell[] += {"CBA_545x39_AK", "CBA_545x39_RPK"};
};

class LMG_03_base_F : Rifle_Long_Base_F {
magazineWell[] = {"CBA_556x45_MINIMI"};
magazineWell[] += {"CBA_556x45_MINIMI"};
};

class LMG_Mk200_F : Rifle_Long_Base_F {
magazineWell[] = {"CBA_65x39_Mk200"};
magazineWell[] += {"CBA_65x39_Mk200"};
};

class LMG_Zafir_F : Rifle_Long_Base_F {
magazineWell[] = {"CBA_762x54R_LINKS"};
magazineWell[] += {"CBA_762x54R_LINKS"};
};

class launch_RPG7_F : Launcher_Base_F {
magazineWell[] = {"CBA_RPG7"};
magazineWell[] += {"CBA_RPG7"};
};

class MMG_01_base_F : Rifle_Long_Base_F {
magazineWell[] = {"CBA_93x64_LINKS"};
magazineWell[] += {"CBA_93x64_LINKS"};
};

class MMG_02_base_F : Rifle_Long_Base_F {
magazineWell[] = {"CBA_338NM_LINKS"};
magazineWell[] += {"CBA_338NM_LINKS"};
};
};
1 change: 0 additions & 1 deletion addons/jam/magwells_357Mag.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@

class CBA_357_6rnds {}; // 6 loose rounds of .357 Magnum
class CBA_357_5rnds {}; // 5 loose rounds of .357 Magnum

4 changes: 3 additions & 1 deletion addons/jam/magwells_545x39.hpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class CBA_545x39_AK { // Standard AK-74 magazines
class CBA_545x39_AK { //This is DEPRECATED! Don't use it! Use the vanilla one instead
BI_mags[] = {
"30Rnd_545x39_Mag_F",
"30Rnd_545x39_Mag_Green_F",
Expand All @@ -7,4 +7,6 @@
};
};

class AK_545x39 {}; // Standard AK-74 magazines

class CBA_545x39_RPK {}; // 45rnd RPK-74
11 changes: 9 additions & 2 deletions addons/jam/magwells_556x45.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,14 @@
};
};

class M249_556x45 {};

class CBA_556x45_TYPE97 {}; // QBZ-97 Stick Mags
class CBA_556x45_TYPE97_XL {}; // QBB-97 LSW Drums
class CBA_556x45_SG550 {};

class CBA_556x45_STANAG { // STANAG mags, standard length, including small drums

class CBA_556x45_STANAG { //This is DEPRECATED! Don't use it! Use the vanilla one instead
BI_mags[] = {
"30Rnd_556x45_Stanag",
"30Rnd_556x45_Stanag_green",
Expand All @@ -28,7 +31,11 @@
};
};

class CBA_556x45_STANAG_L {}; // STANAG mags, long stick or coffin (40/60 rounds, Magpul PMAG 40, Surefire MAG5-60)
class CBA_556x45_STANAG_L {}; //This is DEPRECATED! Don't use it! Use the vanilla one instead

class STANAG_556x45 {}; // STANAG mags, standard length, including small drums

class STANAG_556x45_Large {}; // STANAG mags, long stick or coffin (40/60 rounds, Magpul PMAG 40, Surefire MAG5-60)
class CBA_556x45_STANAG_XL {}; // STANAG mags, extra long stick or coffin (80/100 rounds, Surefire MAG5-100)
class CBA_556x45_STANAG_2D {}; // STANAG mags, twin drums (100rnd Beta C-MAG)
class CBA_556x45_STANAG_2D_XL { // STANAG mags, extra large twin-drums (150rnd Armatac SAW-MAG)
Expand Down
10 changes: 8 additions & 2 deletions addons/jam/magwells_580x42.hpp
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
class CBA_580x42_TYPE95 { // QBZ-95 Stick Mags
class CBA_580x42_TYPE95 { //This is DEPRECATED! Don't use it! Use the vanilla one instead
BI_mags[] = {
"30Rnd_580x42_Mag_F",
"30Rnd_580x42_Mag_Tracer_F"
};
};

class CBA_580x42_TYPE95_XL { // QBB-95 LSW Drums
class CBA_580x42_TYPE95_XL { //This is DEPRECATED! Don't use it! Use the vanilla one instead
BI_drums[] = {
"100Rnd_580x42_Mag_F",
"100Rnd_580x42_Mag_Tracer_F"
};
};


class CTAR_580x42 {}; // QBZ-95 Stick Mags

class CTAR_580x42_Large {}; // QBB-95 LSW Drums

15 changes: 12 additions & 3 deletions addons/jam/magwells_65x39.hpp
Original file line number Diff line number Diff line change
@@ -1,28 +1,37 @@
class CBA_65x39_MX {
class CBA_65x39_MX { //This is DEPRECATED! Don't use it! Use the vanilla one instead
BI_mags[] = {
"30Rnd_65x39_caseless_mag",
"30Rnd_65x39_caseless_green",
"30Rnd_65x39_caseless_mag_Tracer",
"30Rnd_65x39_caseless_green_mag_Tracer"
};
};


class MX_65x39 {};

class CBA_65x39_MX_XL {
BI_mags[] = {
"100Rnd_65x39_caseless_mag",
"100Rnd_65x39_caseless_mag_Tracer"
};
};

class CBA_65x39_Mk200 {

class CBA_65x39_Mk200 { //This is DEPRECATED! Don't use it! Use the vanilla one instead
BI_mags[] = {
"200Rnd_65x39_cased_Box",
"200Rnd_65x39_cased_Box_Tracer"
};
};

class CBA_65x39_Katiba {
class CBA_65x39_Katiba { //This is DEPRECATED! Don't use it! Use the vanilla one instead
BI_mags[] = {
"30Rnd_65x39_caseless_green",
"30Rnd_65x39_caseless_green_mag_Tracer"
};
};

class Mk200_65x39 {};

class Katiba_65x39 {};
4 changes: 3 additions & 1 deletion addons/jam/magwells_762x39.hpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class CBA_762x39_AK { // Standard AK-47/AKM magazines
class CBA_762x39_AK { //This is DEPRECATED! Don't use it! Use the vanilla one instead
BI_mags[] = {
"30Rnd_762x39_Mag_F",
"30Rnd_762x39_Mag_Green_F",
Expand All @@ -7,6 +7,8 @@
};
};

class AK_762x39 {}; // Standard AK-47/AKM magazines

class CBA_762x39_RPK {}; // 40/45/75rnd RPK magazines

class CBA_762x39_STANAG {}; // 762x39mm in a normal length STANAG mag, including small drums
Expand Down