WIP: Arma vanilla magwells

[dedmen]

This is how it would look if we replace our magwells by the vanilla ones.
Need feedback. What do we do?

Leave the BI magwells be and just make our own duplicates?
Add inheritance? Problem with that is, mods that already add onto the CBA classes will break when we add inheritance. But right now it's soon enough that we can still do it.

Also the BI magwells are missing the reload tracers
30Rnd_556x45_Stanag_green, 30Rnd_556x45_Stanag_red and the mx variants.

[jonpas]

Need feedback. What do we do?

Inherit CBA ones from BI ones, remove 1 or 3 versions later.

[jonpas]

Drop the "This is" and just write // DEPRECATED! Don't use! Use vanilla one instead!. The shorter it is, more people read it.

[commy2]

You should name "the vanilla one".

[jonpas]

DEPRECATED! Use 'BI_wellName'!

[robalo]

I would like to see how the vanilla classes look like. Where are they ? Dev ? RC doesn't have any.
The mix of non-tagged with CBA tagged classes looks a bit messy at first sight.

[robalo]

My 0.02€

Unless vanilla implementation promises to get as developed as the current CBA one, deprecation should work the other way around. Deprecate vanilla classes and use a the complete and consistent CBA classes.

[Kllrt]

@robalo They look like this https://pastebin.com/bfa806BH

[Soldia1138]

What’s about e.g. the 100 Round MX magazines? The are commented out in the pasteboard but belong to the same config like the 30 round MX.
CBA has two different entries there.
The potential of conflicts is pretty high with a mixed approach.

Would be easier for us to stay on CBA-only magwells

[dedmen]

Weapon and magazine mod makers will always want to use the Vanilla variant, because they also want to be compatible with users who are not using CBA.
Meaning if we decide to keep a duplicate, they will have to add their magazines to vanilla and CBA. And they will also have to consume the magazines from vanilla and CBA, causing duplicates everywhere.
We can't really deprecate vanilla classes, as we cannot just force every weapon mod maker to depend on CBA.

[robalo]

I'd rather have just a few duplicates - seeing how few the vanilla classes are (if those are real) - than confuse the hell out of everyone with a mixed approach.

[dedmen]

if those are real

@Kllrt is a BI dev btw.

[robalo]

if those are real

@Kllrt is a BI dev btw.

I had no idea :D 🙇

[PabstMirror]

If we are going to keep vanilla magwells I guess we might want something like

class arifle_MX_Base_F: Rifle_Base_F {
    magazineWell[]+= {"CBA_65x39_MX", "CBA_65x39_MX_XL"};

[dedmen]

Btw why do we indent everything in the include files by one level?

[commy2]

Waste of space.
The #include is already indented.

[robalo]

Noticed the magwells were added in latest update. IMO to keep the implementation clean we should go with inheriting from the base classes. Even if it will cause some updating classes RPT errors, for existing JAM-based configs, it won't break the game and they will be spotted and fixed easily.

What I don't like and expect will happen regardless of how we do it is modders throwing all their mags in the vanilla classes without care for the standard/large/drums etc distinction we have already. I still think that we should inverse the deprecation messages and say for example don't use AK_762x39, use CBA_762x39_AK and CBA_762x39_RPK instead.

[dedmen]

we should go with inheriting from the base classes

Inheritance was broken. And I didn't hear of a fix so far.

Theoretically.... Could we do both? Have a inherited CBA class (once inheritance is fixed) and a seperate one too? Nah... I guess that will make things worse? Not sure.

So far I'm on the "deprecate vanilla ones" side too, even though I still don't like having everything twice...

@commy2 seperate PR to fix that someday?

[robalo]

Hmm, dunno about inheritance broken. Seems fine to me:

[PabstMirror]

won't that lead to problems with mod load order?

[robalo]

There is no 40mm magwell in vanilla.

[dedmen]

+= won't break if the array exists right? So it doesn't really matter

[robalo]

Yep, but that's the thing, doesn't exist, same thing on the UGL_F parent.

[dedmen]

Actually meant the opposite as what I said. So does += here break in it's current state? or is it just a minor issue?

[robalo]

Last I checked this kind of array addition combined with inheritance was really finicky.
The above bits seem fine though, did a quick check and magazineWell is populated.

[robalo]

How about this stupid idea: we go with all new untagged classes, vanilla style, extending current vanilla implementation, deprecating everything CBA_ in magwells.

[Drofseh]

It might work, but it'll be kind of a pain.

[jonpas]

Ideal would be if we could give extra classes to BI to add to vanilla... @Kllrt!

[dedmen]

Hmm, dunno about inheritance broken. Seems fine to me:

Yes. But Arma doesn't see it that way. The magazine code doesn't look through parent entries.

Ideal would be if we could give extra classes to BI to add to vanilla..

And take a month or two everytime someone notices that something is missing?

Ideal would be to put everything of CBA into vanilla... Sooo...

[jonpas]

Well that's what you get, it's in vanilla, that's a big enough pro for a small wait of 2-3 months.

[robalo]

So which way from here:

1. Stick with what we got done, vanilla and CBA magwells can live happily side by side attached to weapons as modders see fit depending on whether they need/want to support CBA JAM.
2. Figure out new class naming convention that looks consistent with vanilla naming and still makes sense and propose BIS to include them or at least be aware of them.

For 1. I still feel that we should not deprecate existing CBA magwells in favor of vanilla, Keeping them may cause some duplication to pop up but don't see what harm that may cause really.

[jonpas]

I vote 2, 1 if 2 won't go through.

[commy2]

Voting for vanilla in parallel with CBA.

[commy2]

Is this obsolete now? Close?

[dedmen]

@commy2 yes.
But this
https://github.com/CBATeam/CBA_A3/pull/1030/files#diff-a59084d33a95ff61239e5b86ef372144L8
+= is still needed. See comment on the 1.92 magwell PR. We currently break mods and might break vanilla again with next update.