Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAM update for 1.86 #1041

Closed
wants to merge 2 commits into from
Closed

JAM update for 1.86 #1041

wants to merge 2 commits into from

Conversation

robalo
Copy link
Contributor

@robalo robalo commented Dec 4, 2018

Updates instead of overriding vanilla magwells.
Inherit from existing vanilla magwells.
Remove leading spaces.

@robalo
Copy link
Contributor Author

robalo commented Dec 4, 2018

Just to see what I was talking about in #1030

@PabstMirror
Copy link
Contributor

With current ace, it causes a UBC error, which wipes out the inherited BI mags

Updating base class MX_65x39->, by z\ace\addons\ballistics\config.cpp/CfgMagazineWells/CBA_65x39_MX/ (original (no unload))
Updating base class Mk200_65x39->, by z\ace\addons\ballistics\config.cpp/CfgMagazineWells/CBA_65x39_Mk200/ (original (no unload))
Updating base class STANAG_556x45->, by z\ace\addons\ballistics\config.cpp/CfgMagazineWells/CBA_556x45_STANAG/ (original (no unload))

image

@robalo
Copy link
Contributor Author

robalo commented Dec 4, 2018

I see what you mean. Existing implementation can override the inheritance. Could've left the vanilla mags un-commented in the CBA child classes to avoid losing them that way.
But then, what would be the point of the inheritance. Gah ! LOL.

@dedmen
Copy link
Contributor

dedmen commented Dec 5, 2018

Did you test if these actually work? As I said, inheritance was broken and reyhard never told me if he fixed it.

@PabstMirror
Copy link
Contributor

    class arifle_MX_test_F : arifle_MX_SW_F {
        displayName = "0 Test Gun";
        scope = 2;
        magazineWell[] = {"CBA_65x39_MX"};
        magazines[] = {};
    };

Config wise it should work, but I can't load the mag in
image

Good call @dedmen, biki has same warning

// It's possible to add new arrays to class but for now inheritance (i.e. STANAG_556x45_New: STANAG_556x45 {};) is not supported

@robalo
Copy link
Contributor Author

robalo commented Dec 5, 2018

This PR is a fail, scrap it, concentrate on #1030

@robalo robalo closed this Dec 5, 2018
@commy2 commy2 deleted the jam_186 branch December 6, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants