Overhaul activateAddons

[dedmen]

Cache the addons list at game start instead of always iterating through config at preInit.
Create a "sparse" list with only the addons that really need to be passed to activateAddons because activateAddons is VERY slow.

CBA common preInit is the 3rd slowest in my modset, and this code is the main cause.

Left of the red line you can see the iteration through config right after the preprocess and compile for the init functions. Red line is the call to activateAddons.

[commy2]

"sparse"?

[dedmen]

https://en.wikipedia.org/wiki/Sparse_file. Got a better name?

Before:

3,334 is the config lookup. And the empty space is the activate Addons.
314ms total for preinit
After:

115ms for activate addons. 155ms total for preInit

Prestart:

By filtering out addons with empty units we get from 3342 down to 1181 (with my modset)
CfgAddons stuff is apparently broken. whoops.

[commy2]

Test with only CBA, CBA + ACE, and then with whatever you're using and compare them all.

[dedmen]

Fixed. Only 412 addons left if you filter out empty ones or already loaded ones.
That's 412 addons passed to activateAddons, instead of previously 3342.

common preinit down to 114ms for activateAddons and 137ms total time.

and compare them all

I have things to do you know?

One run takes like 5 minutes.

[PabstMirror]

ace uses activatedAddons command which dropped from count 1419 down to 1312

https://github.com/acemod/ACE3/blob/master/addons/common/scripts/checkVersionNumber.sqf#L10

We should probably just start using cba_common_addons, which should contain the original values

[commy2]

activatedAddons definitely should not be used, because even some modules break it.
On the other hand, I am not sure we should also break it, just because of some milliseconds.

[jonpas]

I have things to do you know?

So do most people... you are no special furry! 😆

[commy2]

We badly need multiline suggestions.

[commy2]

I like everything, except the variable names. With my suggestions the script becomes more "poetic" I think.

Also needs toLower I'd say.