Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add P90, UMP40/45/9 & Beretta M9 magwells #1061

Merged
merged 4 commits into from
Feb 15, 2019
Merged

Add P90, UMP40/45/9 & Beretta M9 magwells #1061

merged 4 commits into from
Feb 15, 2019

Conversation

3Mydlo3
Copy link
Contributor

@3Mydlo3 3Mydlo3 commented Feb 10, 2019

When merged this pull request will:

  • Add FN P90 magwell
  • Add magwell support to vanilla P90
  • Add HK UMP 40/45/9 magwells
  • Add Beretta M9 magwell
  • Add FN Five-Seven magwell
  • Add Zastava M21 magwell
  • Add Zastava M76 magwell

Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@commy2 commy2 added this to the 3.10 milestone Feb 10, 2019
@Drofseh
Copy link
Contributor

Drofseh commented Feb 10, 2019

@3Mydlo3 Could you add a magwell for the FN Five-seven pistol to magwells_570x28.hpp as well? <3

@3Mydlo3
Copy link
Contributor Author

3Mydlo3 commented Feb 11, 2019

  • Added FN57 magwell as @Drofseh wished.
  • Added Zastava M21, Zastava M76 & Sa vz. 61 Scorpion magwells based on RHS GREF/SAF weapons as I created CBA magwell compat for them.

I might add some more as I create Unsung compat.
I didn't expect this PR to grow, maybe it will be a good idea to change it's title? I don't want to do it myself because I don't know if that's ok.

@Drofseh
Copy link
Contributor

Drofseh commented Feb 11, 2019

@3Mydlo3 7.65x17mm already exists in magwells_32ACP.hpp
They are the same thing.

#include "magwells_32ACP.hpp" // .32 ACP | .32 Automatic | 7.65x17mmSR Browning | 7.65 mm Browning Short

@3Mydlo3
Copy link
Contributor Author

3Mydlo3 commented Feb 11, 2019

@Drofseh Oh, I don't know how I missed it. Sorry. I'll update shortly.

7.65x17mm already exists in `magwells_32ACP.hpp`
@Drofseh
Copy link
Contributor

Drofseh commented Feb 12, 2019

No worries. My first reaction was "I thought I added that earlier, did I miss it?".

@commy2 commy2 merged commit 7224d20 into CBATeam:master Feb 15, 2019
@PabstMirror PabstMirror mentioned this pull request Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants