-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More magwells #1076
Merged
Merged
More magwells #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change 570x28 to 57x28, since the cartridge is always called the 5.7x28mm - Add .45 ACP fullsize Glock magwell to SMG_01 (Vermin SMG/KRISS Vector) - Add 9x19mm Scorpion Evo 3 magwell for SMG_02 (Sting 9mm/CZ Skorpion Evo) - Add 9x19mm MP5 magwell to SMG_05 (Protector 9 mm/MP5K) - Add magwels for the CZ 75, 85, , 97, 2075, P-01, P-06, P-07, P-09
- readd missing line break
changing name from #1061 which hasn't been released, so no compat problems |
commy2
reviewed
Feb 22, 2019
commy2
reviewed
Feb 22, 2019
commy2
reviewed
Feb 22, 2019
commy2
reviewed
Feb 22, 2019
commy2
reviewed
Feb 22, 2019
commy2
suggested changes
Feb 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Co-Authored-By: Drofseh <Drofseh@users.noreply.github.com>
@commy2 requested changes done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
This is more correct and keeps the naming convention of other magwells that do not add trailing zeros.
However I think it would be confusing for players if weapons that appear to be able to interchange magazines with mod weapons aren't able to (for example the vanilla MP5K and the NIA or CUP MP5's).