Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More magwells #1076

Merged
merged 3 commits into from
Feb 23, 2019
Merged

More magwells #1076

merged 3 commits into from
Feb 23, 2019

Conversation

Drofseh
Copy link
Contributor

@Drofseh Drofseh commented Feb 22, 2019

When merged this pull request will:

  • Change 570x28 to 57x28, since the cartridge is always called the 5.7x28mm
    This is more correct and keeps the naming convention of other magwells that do not add trailing zeros.
  • Add magwels for the CZ 75, 85, 97, 2075, P-01, P-06, P-07, P-09 for Urban.
  • Add .45 ACP fullsize Glock magwell to SMG_01 (Vermin SMG/KRISS Vector)
  • Add 9x19mm Scorpion Evo 3 magwell for SMG_02 (Sting 9mm/CZ Skorpion Evo)
  • Add 9x19mm MP5 magwell to SMG_05 (Protector 9 mm/MP5K)
  • I'm not 100% happy with having these vanilla two vanilla SMGs as 9x19mm since in vanilla they use 9x21mm and because they should not be able to interchange magazines with each other IRL.
    However I think it would be confusing for players if weapons that appear to be able to interchange magazines with mod weapons aren't able to (for example the vanilla MP5K and the NIA or CUP MP5's).

- Change 570x28 to 57x28, since the cartridge is always called the 5.7x28mm
- Add .45 ACP fullsize Glock magwell to SMG_01 (Vermin SMG/KRISS Vector)
- Add 9x19mm Scorpion Evo 3 magwell for SMG_02 (Sting 9mm/CZ Skorpion Evo)
- Add 9x19mm MP5 magwell to SMG_05 (Protector 9 mm/MP5K)
- Add magwels for the CZ 75, 85, , 97, 2075, P-01, P-06, P-07, P-09
- readd missing line break
@PabstMirror
Copy link
Contributor

changing name from #1061 which hasn't been released, so no compat problems

addons/jam/CfgWeapons.hpp Outdated Show resolved Hide resolved
addons/jam/CfgWeapons.hpp Outdated Show resolved Hide resolved
addons/jam/CfgWeapons.hpp Outdated Show resolved Hide resolved
addons/jam/CfgWeapons.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Co-Authored-By: Drofseh <Drofseh@users.noreply.github.com>
@Drofseh
Copy link
Contributor Author

Drofseh commented Feb 22, 2019

@commy2 requested changes done.

@commy2 commy2 added this to the 3.10 milestone Feb 23, 2019
@commy2 commy2 merged commit f9b748e into CBATeam:master Feb 23, 2019
@Drofseh Drofseh deleted the moreMagwells branch February 23, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants