Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix headDir 1.92 #1129

Merged
merged 1 commit into from
Apr 30, 2019
Merged

fix headDir 1.92 #1129

merged 1 commit into from
Apr 30, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Apr 30, 2019

When merged this pull request will:

@commy2 commy2 added the Bug Fix label Apr 30, 2019
@commy2 commy2 added this to the 3.10.2 milestone Apr 30, 2019
PabstMirror
PabstMirror approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PabstMirror
Copy link
Contributor

Might be able to simplify with https://community.bistudio.com/wiki/getCameraViewDirection in the future

@commy2
Copy link
Contributor Author

commy2 commented Apr 30, 2019

Everything with vectorNormalized-vectorMultiply-vectorMagnitude can be improved with https://community.bistudio.com/wiki/vectorLinearConversion

@commy2 commy2 modified the milestones: 3.10.2, 3.11 Apr 30, 2019
@commy2 commy2 merged commit bda8d8d into master Apr 30, 2019
@commy2 commy2 deleted the fixHeadDir branch April 30, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
3.11
Development

Successfully merging this pull request may close these issues.

CBA_fnc_headDir broken in 1.92
2 participants
@commy2 @PabstMirror