-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more params to notify function #1146
Conversation
I am not sure I like this. Priority notifications yes, but this will just make everyone force show. We should clearly specify to use this rarely or something like that. |
I noticed the same problem. Is the function still backwards compatible with the changed params? My idea was to have a priority value (NUMBER) for each notification and that changes the position in queue including potentially changing the displayed notification (maybe pusing the previous one to be displayed again down the queue). |
It's not backwards compatible. Maybe change the queue param to |
If it's not backward compatible make it a new function. |
Sounds good, except that I would make those two different params (arguments). |
I would prefer "don't stop queue" parameter instead of "force show", meaning if another notification comes in, it instantly overwrites it. Also solves the problem of mods forcing away important notifications with less important ones, but at the same time hides specifically marked less important ones right away. I like lifetime. |
Replaced by #1175. |
When merged this pull request will:
I've noticed that the queue prevent to display "urgent notifications" which you can't avoid.
With the provided lifetime and
queue
parameter you're able to clear the queue and therefore display directly an urgent notification.