Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify - Skippable parameter, Lifetime Setting, Use in Accessory component #1175

Merged
merged 10 commits into from
Jul 6, 2019

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Jul 3, 2019

When merged this pull request will:

  • Replace Add more params to notify function #1146
  • Add Notify _skippable parameter, making the notification get immediately replaced if another enters queue
    • Uses CBA_fnc_waitAndExecute as before for non-skippable (default) notifications
    • Uses CBA_fnc_waitUntilAndExecute for skippable notifications, checks if any new notification entered, moves directly to it, otherwise fades it away after timeout (lifetime)
  • Add Notify "Notification Lifetime" setting
    • Move UI settings to own file
    • Use CBA_fnc_addSetting for "Store Passwords" setting
  • Use Notify in Accessory component - close Accessory Functions not using CBA_fnc_notify #1167
    • Add attachment image (config entry "picture") display
    • Remove Accessory "no weapon in hands" hint/notification

https://i.imgur.com/g40d4df.gifv

@jonpas jonpas added this to the 3.12 milestone Jul 3, 2019
@jonpas jonpas requested a review from commy2 July 3, 2019 18:34
@jonpas jonpas marked this pull request as ready for review July 3, 2019 18:47
@commy2 commy2 merged commit 508ebd3 into master Jul 6, 2019
@commy2 commy2 deleted the notify-params branch July 6, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessory Functions not using CBA_fnc_notify
3 participants