Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BI's new matrix commands #1173

Merged
merged 2 commits into from
Jun 30, 2019
Merged

Use BI's new matrix commands #1173

merged 2 commits into from
Jun 30, 2019

Conversation

Kexanone
Copy link
Contributor

When merged this pull request will:

@jonpas
Copy link
Member

jonpas commented Jun 30, 2019

Needs deprecation markers.

dedmen
dedmen reviewed Jun 30, 2019
View reviewed changes
addons/vectors/fnc_matrixProduct3D.sqf
@@ -26,8 +26,4 @@ Author:

params [["_matrixA", [], [[]], 3], ["_matrixB", [], [[]], 3]];

_matrixB = [_matrixB] call CBA_fnc_matrixTranspose;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did the transpose go?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for transpose anymore. It was just a workaround for an easier access to column vectors as 1D arrays, since vectorDotProduct only supports 1D arrays.

@Kexanone
Copy link
Contributor Author

Kexanone commented Jun 30, 2019 •
edited
Loading

Needs deprecation markers.

Yes, I would say all except CBA_fnc_vectMap3D. Not sure how to correctly mark them though. By comment or are there macros?

@commy2
Copy link
Contributor

commy2 commented Jun 30, 2019

Just a comment https://github.com/CBATeam/CBA_A3/blob/master/addons/vectors/fnc_vectDot.sqf

@commy2
Copy link
Contributor

commy2 commented Jun 30, 2019

Or this: https://github.com/CBATeam/CBA_A3/blob/master/addons/common/fnc_isUnitGetOutAnim.sqf

@commy2
Copy link
Contributor

commy2 commented Jun 30, 2019

Someone use

execVM "\x\cba\addons\vectors\test_vectors.sqf";

@jonpas
Copy link
Member

jonpas commented Jun 30, 2019

@commy2 when does it get moved to backwards_comp.sqf and a WARNING is printed?

@commy2
Copy link
Contributor

commy2 commented Jun 30, 2019

Never?

@jonpas
Copy link
Member

jonpas commented Jun 30, 2019

What is this then? https://github.com/CBATeam/CBA_A3/blob/master/addons/common/backwards_comp.sqf

@dedmen
Copy link
Contributor

dedmen commented Jun 30, 2019

See https://github.com/CBATeam/CBA_A3/blob/master/addons/vectors/XEH_preInit.sqf#L6

@commy2
Copy link
Contributor

commy2 commented Jun 30, 2019

None of the other vector component functions have a warning, even if they got engine or BI functions.

@jonpas
Copy link
Member

jonpas commented Jun 30, 2019

Inconsistency bothers me.

@commy2
Copy link
Contributor

commy2 commented Jun 30, 2019

Keep it consistent with the rest of vectors component.

@Kexanone
Copy link
Contributor Author

Looks fine:

21:07:56 [CBA] (vectors) Test OK: (CBA_fnc_vectMap3D is defined) x\cba\addons\vectors\test_vectors.sqf:316
21:07:56 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:320
21:07:56 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:324
21:07:56 [CBA] (vectors) Test OK: (CBA_fnc_matrixTranspose is defined) x\cba\addons\vectors\test_vectors.sqf:328
21:07:56 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_matrixEquals) x\cba\addons\vectors\test_vectors.sqf:332
21:07:56 [CBA] (vectors) Test OK: (CBA_fnc_matrixProduct3D is defined) x\cba\addons\vectors\test_vectors.sqf:336
21:07:56 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_matrixEquals) x\cba\addons\vectors\test_vectors.sqf:340
21:07:56 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_matrixEquals) x\cba\addons\vectors\test_vectors.sqf:346

If deprecation conventions should be changed for vectors component, it should clearly be dealt with in a different PR.

@jonpas
Copy link
Member

jonpas commented Jun 30, 2019

If deprecation conventions should be changed for vectors component, it should clearly be dealt with in a different PR.

Yes, not talking about changing it in this PR, or at all really.

@commy2 commy2 added this to the 3.12 milestone Jun 30, 2019
@commy2 commy2 added the Cleanup label Jun 30, 2019
@commy2
Copy link
Contributor

commy2 commented Jun 30, 2019

Don't merge before those commands are in stable.

@Kexanone
Copy link
Contributor Author

Kexanone commented Jun 30, 2019 •
edited
Loading

They are in stable though.

@commy2 commy2 merged commit 42622e9 into CBATeam:master Jun 30, 2019
@Kexanone Kexanone deleted the update-linalg branch July 1, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedmen dedmen dedmen left review comments

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
3.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kexanone @jonpas @commy2 @dedmen