Add basic functions for change of basis in 3D #939

Kexanone · 2018-06-22T18:44:20Z

When merged this pull request will:

Add CBA_fnc_matrixProduct3D for the product of two 3x3-matrices.
Add CBA_fnc_matrixTranspose for transposing a mxn-matrix.
Add CBA_fnc_vectMap3D for 3x3-matrix - 3D-vector multiplication.

dedmen · 2018-06-22T22:08:43Z

addons/vectors/fnc_matrixTranspose.sqf

+for "_j" from 0 to (_n - 1) do
+{
+    private _returnRow = [];
+    for "_i" from 0 to (_m - 1) do


use apply here?

Agreed, the same goes for CBA_fnc_matrixProduct3D.

commy2 · 2018-06-23T00:33:13Z

Made some ocd style fixes.
These probably should have unit tests here.

dedmen · 2018-06-23T15:39:59Z

addons/vectors/test_vectors.sqf

@@ -12,13 +12,28 @@ private _fnc_vectorEquals = {
    if ((count _vector1) != (count _vector2)) exitWith {false};
    private _equal = true;
    {
-        if ((abs (_x - (_vector2 select _forEachIndex))) > 0.00001) then {


can be replaced by findIf I think.

findif does not support _forEachIndex

No need to, findIf is kind of hard to read.

commy2 · 2018-06-30T07:33:06Z

execVM "\x\cba\addons\vectors\test_vectors.sqf"

 9:31:27 [CBA] (vectors) LOG: Testing Vectors x\cba\addons\vectors\test_vectors.sqf:39
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_polar2vect is defined) x\cba\addons\vectors\test_vectors.sqf:43
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:47
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:51
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:55
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:59
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_scaleVect is defined) x\cba\addons\vectors\test_vectors.sqf:64
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:68
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:72
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:76
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_scaleVectTo is defined) x\cba\addons\vectors\test_vectors.sqf:81
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:85
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:89
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:93
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:97
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_simplifyAngle is defined) x\cba\addons\vectors\test_vectors.sqf:102
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle x\cba\addons\vectors\test_vectors.sqf:106
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle x\cba\addons\vectors\test_vectors.sqf:110
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle x\cba\addons\vectors\test_vectors.sqf:114
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_simplifyAngle180 is defined) x\cba\addons\vectors\test_vectors.sqf:119
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle180 x\cba\addons\vectors\test_vectors.sqf:123
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle180 x\cba\addons\vectors\test_vectors.sqf:127
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle180 x\cba\addons\vectors\test_vectors.sqf:131
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vect2Polar is defined) x\cba\addons\vectors\test_vectors.sqf:136
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:140
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:144
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:148
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:152
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectAdd is defined) x\cba\addons\vectors\test_vectors.sqf:158
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:162
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:166
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectCross is defined) x\cba\addons\vectors\test_vectors.sqf:172
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:176
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectCross2D is defined) x\cba\addons\vectors\test_vectors.sqf:181
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectCross2D x\cba\addons\vectors\test_vectors.sqf:185
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectDir is defined) x\cba\addons\vectors\test_vectors.sqf:190
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectDir x\cba\addons\vectors\test_vectors.sqf:194
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectDir x\cba\addons\vectors\test_vectors.sqf:198
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectDot is defined) x\cba\addons\vectors\test_vectors.sqf:203
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectDot x\cba\addons\vectors\test_vectors.sqf:207
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectDot x\cba\addons\vectors\test_vectors.sqf:211
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectElev is defined) x\cba\addons\vectors\test_vectors.sqf:216
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectElev x\cba\addons\vectors\test_vectors.sqf:220
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectElev x\cba\addons\vectors\test_vectors.sqf:224
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectMagn is defined) x\cba\addons\vectors\test_vectors.sqf:229
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectMagn x\cba\addons\vectors\test_vectors.sqf:233
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectMagn x\cba\addons\vectors\test_vectors.sqf:237
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectMagn2D is defined) x\cba\addons\vectors\test_vectors.sqf:242
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectMagn2D x\cba\addons\vectors\test_vectors.sqf:246
 9:31:27 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectMagn2D x\cba\addons\vectors\test_vectors.sqf:250
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectRotate2D is defined) x\cba\addons\vectors\test_vectors.sqf:255
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:259
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:263
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectRotate3D is defined) x\cba\addons\vectors\test_vectors.sqf:267
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:271
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:275
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:279
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:283
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:287
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:291
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectSubtract is defined) x\cba\addons\vectors\test_vectors.sqf:295
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:299
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:306
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:311
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_vectMap3D is defined) x\cba\addons\vectors\test_vectors.sqf:316
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:320
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:324
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_matrixTranspose is defined) x\cba\addons\vectors\test_vectors.sqf:328
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_matrixEquals) x\cba\addons\vectors\test_vectors.sqf:332
 9:31:27 [CBA] (vectors) Test OK: (CBA_fnc_matrixProduct3D is defined) x\cba\addons\vectors\test_vectors.sqf:336
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_matrixEquals) x\cba\addons\vectors\test_vectors.sqf:340
 9:31:27 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_matrixEquals) x\cba\addons\vectors\test_vectors.sqf:346

Kexanone added 3 commits June 22, 2018 20:34

Add basic functions for change of basis in 3D

22a14f2

Update CfgFunctions.hpp

0884e85

Replace tabs with spaces in fnc_matrixProduct3D

ab4efd8

dedmen reviewed Jun 22, 2018

View reviewed changes

Kexanone and others added 8 commits June 23, 2018 01:25

Replace for loops with apply

c2cf66c

Standardize comment indentation

efe1e00

Fix comment grammar

cf63434

delete semicolon to indicate function return value

89e47f8

delete semicolon to indicate function return value

41bc3ea

delete semicolon to indicate function return value

8a9d880

delete atypical empty line

e998ed6

delete atypical empty line

f11acdb

Kexanone added 2 commits June 23, 2018 17:18

Optimize _fnc_vectorEquals and implement _fnc_matrixEquals

99185c1

Add unit tests

c29d3b4

dedmen reviewed Jun 23, 2018

View reviewed changes

Kexanone mentioned this pull request Jun 23, 2018

Revise template format (WIP) LISTINGS09/ZEI#6

Closed

dedmen mentioned this pull request Jun 24, 2018

Fix script errors reporting wrong line numbers #937

Merged

commy2 added the Feature label Jun 25, 2018

commy2 added this to the 3.8 milestone Jun 25, 2018

commy2 self-assigned this Jun 25, 2018

commy2 added 3 commits June 30, 2018 09:26

include position

b0456e5

include position

a5995d1

include position

df3d6a6

commy2 approved these changes Jun 30, 2018

View reviewed changes

commy2 merged commit 0a9bb8a into CBATeam:master Jun 30, 2018

Kexanone mentioned this pull request Jun 30, 2019

Use BI's new matrix commands #1173

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic functions for change of basis in 3D #939

Add basic functions for change of basis in 3D #939

Kexanone commented Jun 22, 2018

dedmen Jun 22, 2018

Kexanone Jun 22, 2018 •

edited

Loading

commy2 commented Jun 23, 2018

dedmen Jun 23, 2018

Kexanone Jun 23, 2018

commy2 Jun 23, 2018

commy2 commented Jun 30, 2018

Add basic functions for change of basis in 3D #939

Add basic functions for change of basis in 3D #939

Conversation

Kexanone commented Jun 22, 2018

dedmen Jun 22, 2018

Choose a reason for hiding this comment

Kexanone Jun 22, 2018 • edited Loading

Choose a reason for hiding this comment

commy2 commented Jun 23, 2018

dedmen Jun 23, 2018

Choose a reason for hiding this comment

Kexanone Jun 23, 2018

Choose a reason for hiding this comment

commy2 Jun 23, 2018

Choose a reason for hiding this comment

commy2 commented Jun 30, 2018

Kexanone Jun 22, 2018 •

edited

Loading