Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joint rails - enoch attachment classes compatibility - Variant A #1184

Merged
merged 6 commits into from
Jul 27, 2019

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 26, 2019

This PR fixes the following UBC classes since Arma 1.94 = Enoch:

 9:02:51 Cannot delete class PointerSlot, it is referenced somewhere (used as a base class probably).
 9:02:51 Updating base class MuzzleSlot_65->asdg_MuzzleSlot_65, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_F/WeaponSlotsInfo/MuzzleSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot_Rail->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_F/WeaponSlotsInfo/PointerSlot/ (original (no unload))
 9:02:51 Updating base class MuzzleSlot_65->asdg_MuzzleSlot_65, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_GL_F/WeaponSlotsInfo/MuzzleSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot_Rail->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_GL_F/WeaponSlotsInfo/PointerSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot_Rail->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_SW_F/WeaponSlotsInfo/PointerSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot_Rail->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MXM_F/WeaponSlotsInfo/PointerSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_AK12_base_F/WeaponSlotsInfo/PointerSlot/ (original a3\weapons_f_exp\rifles\ak12\config.bin)
 9:02:51 Updating base class UnderBarrelSlot_rail->asdg_UnderSlot, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_AK12_F/WeaponSlotsInfo/UnderBarrelSlot/ (original (no unload))

This means that we drop Joint Rails support for muzzle and pointer slots of the MX series, and pointer and bipod support for the AK12 series.

The benefit of this is, that addons that only add items to the new vanilla attachment classes and no JR, will not be broken by CBA_A3 in the future.

The drawback of this is, that addons that already add items to these specific joint rails classes, will have to add their items to both the new BI classes and the CBA_A3 joint rails classes to support both MX and AK12, as well as future third party classes coping these vanilla attachment classes, as well as old third party classes that already use the joint rails classes.

@commy2 commy2 added Task 1.94 Contact DLC labels Jul 26, 2019
@commy2 commy2 added this to the 3.12.1 milestone Jul 26, 2019
@commy2 commy2 changed the title joint rails - enoch attachment classes compatibility joint rails - enoch attachment classes compatibility - Variant A Jul 26, 2019
@commy2
Copy link
Contributor Author

commy2 commented Jul 26, 2019

May need to check if AK12 public classes not overwrite the attachment classes we have here, which means I'd have to adjust this PR.

@commy2 commy2 added the WIP label Jul 26, 2019
@dedmen
Copy link
Contributor

dedmen commented Jul 26, 2019

Modders are already used to adding to two classes for magazineWells.
However now modders might have to decide whether to inherit from the CBA class, or the vanilla class.
And for now, mod attachments then won't work on stuff that uses vanilla JR. Which I personally don't care about. If you run mod weapons with mod attachments, you prolly don't use vanilla weapons anyway

@commy2

This comment has been minimized.

@commy2
Copy link
Contributor Author

commy2 commented Jul 26, 2019

Changes for attachment base classes due to Enoch:
DMR_01_base_F, EBR_base_F, DMR_03_base_F and DMR_06_base_F:

asdg_MuzzleSlot_762 -> MuzzleSlot_762

mk20_base_F and Tavor_base_F:

asdg_MuzzleSlot_556 -> MuzzleSlot_556

arifle_Katiba_Base_F and LMG_Mk200_F:

asdg_MuzzleSlot_65 -> MuzzleSlot_65

arifle_MX_Base_F:

asdg_MuzzleSlot_65 -> MuzzleSlot_65
asdg_FrontSideRail -> PointerSlot_Rail

arifle_AK12_base_F, arifle_AK12U_base_F and arifle_RPK12_base_F:

asdg_MuzzleSlot_762R -> MuzzleSlot_762
asdg_OpticRail1913 -> CowsSlot_Rail
asdg_UnderSlot -> UnderBarrelSlot_rail

@commy2 commy2 removed the WIP label Jul 26, 2019
@commy2
Copy link
Contributor Author

commy2 commented Jul 26, 2019

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.94 Contact DLC Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants