Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joint rails - enoch attachment classes compatibility - Variant B #1185

Closed
wants to merge 1 commit into from

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 26, 2019

This PR fixes the following UBC classes since Arma 1.94 = Enoch:

 9:02:51 Updating base class MuzzleSlot_65->asdg_MuzzleSlot_65, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_F/WeaponSlotsInfo/MuzzleSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot_Rail->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_F/WeaponSlotsInfo/PointerSlot/ (original (no unload))
 9:02:51 Updating base class MuzzleSlot_65->asdg_MuzzleSlot_65, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_GL_F/WeaponSlotsInfo/MuzzleSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot_Rail->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_GL_F/WeaponSlotsInfo/PointerSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot_Rail->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MX_SW_F/WeaponSlotsInfo/PointerSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot_Rail->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_MXM_F/WeaponSlotsInfo/PointerSlot/ (original (no unload))
 9:02:51 Updating base class PointerSlot->asdg_FrontSideRail, by x\cba\addons
 9:02:51 Updating base class UnderBarrelSlot_rail->asdg_UnderSlot, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_AK12_F/WeaponSlotsInfo/UnderBarrelSlot/ (original (no unload))

This is an alternative to #1184.

We avoid the UBC by deleting the new BI attachment classes in the sub config. But that means that CBA now breaks addons that work fine in vanilla, by deleting attachment compatibility if the author only adds to the vanilla attachment class. Hard pill to swallow and to explain when someone complains.

I like variant A more, but we can merge this one as well.


The remaining errors:

10:02:56 Cannot delete class PointerSlot, it is referenced somewhere (used as a base class probably).
10:02:56 Updating base class PointerSlot->asdg_FrontSideRail, by x\cba\addons\jr\config.cpp/CfgWeapons/arifle_AK12_base_F/WeaponSlotsInfo/PointerSlot/ (original a3\weapons_f_exp\rifles\ak12\config.bin)

will be fixed later today...

@commy2 commy2 added Task WIP 1.94 Contact DLC labels Jul 26, 2019
@commy2 commy2 added this to the 3.12.1 milestone Jul 26, 2019
@jonpas
Copy link
Member

jonpas commented Jul 26, 2019

Prefer A.

@commy2 commy2 closed this Jul 26, 2019
@commy2 commy2 deleted the enoch-jr-compat2 branch July 26, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants