Improve VERSION_CONFIG #1221
Merged
Improve VERSION_CONFIG #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version should always be a number, while versionStr should be a string, no automatic conversions
commy2
approved these changes
Sep 6, 2019
This was referenced Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
VERSION_CONFIGversion number API -versionshould always be a number, whileversionStrshould be a string, without automatic conversions (version = 1.0.1gets converted to string).helpcomponent readversionStrand fall-back toversion.VERSION_CONFIGto macros file and expand wiki page.This PR provides full backwards compatibility, all mods that want to use this new API properly must change it on their end as well. That way, anyone using the API in the wrong manner should not see anything broken in relation to his own mod.