Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup CfgPatches and use VERSION_CONFIG consistently #1222

Merged
merged 2 commits into from
Sep 7, 2019
Merged

Cleanup CfgPatches and use VERSION_CONFIG consistently #1222

merged 2 commits into from
Sep 7, 2019

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Sep 6, 2019 •
edited
Loading

When merged this pull request will:

  • Cleanup all CfgPatches for consistency - follow order in ACE3.
  • Use VERSION_CONFIG in all components - compliments Improve VERSION_CONFIG #1221, previously only version was defined so Credits showed short version v3.12.
  • Use requiredVersion = REQUIRED_VERSION; consistently.
  • Remove now (probably) outdated 4.0.0 version from XEH component.
  • Remove outdated versionDesc.

@jonpas jonpas added this to the 3.13 milestone Sep 6, 2019
@jonpas jonpas requested a review from commy2 September 6, 2019 14:43
commy2
commy2 reviewed Sep 6, 2019
View reviewed changes
addons/main/config.cpp Outdated Show resolved Hide resolved
@commy2
Copy link
Contributor

commy2 commented Sep 7, 2019

Merge now?

@jonpas jonpas merged commit 8a94c03 into master Sep 7, 2019
@jonpas jonpas deleted the use-versioncfg branch September 7, 2019 10:04
@commy2 commy2 modified the milestones: 3.13, 3.12.2 Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
Cleanup Enhancement
Projects
None yet
Milestone
3.12.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jonpas @commy2