Add CBA_fnc_canAddItem

[Dystopian]

When merged this pull request will:

• add function for checking if unit has enough free space in inventory to store item.

canAdd* commands can return false even if there is free space in unit inventory (see this ticket and other about canAdd). These commands take current unit load into account. Sometimes we don't need to check unit load e.g. when taking out ACE Earplugs or weapon accessories.

As usually function and variables names are subject to discuss.

[commy2]

CBA_fnc_canAddItem?

[Dystopian]

CBA_fnc_canAddItem?

I thought about it or even just CBA_fnc_canAdd but I didn't want to confuse it with canAdd command. Anyway for me naming here is not important so I accept any suggestions.

[commy2]

The purpose is the same as the canAdd command though, and it is obvious that they behave differently, since one is a command, the other a function from CBA.

[dedmen]

This has the same issue as canAdd command.
Lets say you add 30 items with 1 space each.
In uniform, you have 12 spaces free, in vest you have 20 spaces free, in backpack you have 29 spaces free.

Yes you can add the 30 items, but canAdd returns false.

My idea for the solution would be to not check if count of items fits, but instead for uniform/vest/backpack instead count how many of the items could fit into each of them.
Sum the number up and check if the possible number of items that can fit is bigger than the requested count.

in my case
uniform could fit 12 items
+ vest can fit 20
+ backpack can fit 29
61 >= 30 -> return true.

instead of what you and canAdd command are doing
accumMass = 30*1

uniform: 12 < 30, false
vest: 20 < 30, false
backpack: 29 < 30, false
-> return false.

I also want to make this change to the canAdd command someday.

[commy2]

What Ded said.

[Dystopian]

count made function a little bit more complex. Maybe function should return item count which can be put to unit? It would make function more universal.

[dedmen]

I think instead of all the seperate exitWiths and stuff, its easier to just count up the total that fit and do one check at the end.
Though less efficient of course 🙃 (I prefer efficiency so just ignore what I said)

[commy2]

lgtm.
Could add another abstraction layer by putting those container checks into a function and passing vest, vestLoad, checkVest and allowSlotVest etc. as arguments.
Would look nicer for sure.

[Dystopian]

I thought about it. But for 3 containers I decided it's not worth it.

[commy2]

Even if you hate it, I am having fun.

#define CAN_ADD_TO(CONTAINER) _check##CONTAINER && {\
    DOUBLES(TYPE,CONTAINER) in _allowedSlots && {\
        _mass == 0 || {\
            _count = _count - floor (getContainerMaxLoad CONTAINER _unit * (1 - load##CONTAINER _unit) / _mass);\
            _count <= 0\
        }\
    }\
}


CAN_ADD_TO(UNIFORM) || {CAN_ADD_TO(VEST) || {CAN_ADD_TO(BACKPACK)}}

[Freddo3000]

This has already been merged, but this problem seems to be tied to this: https://feedback.bistudio.com/T154476

canAdd returning false doesn't have to do with having over a certain amount of items, it has to do with having more than 1000 loadAbs, or 1.00 load on a unit, corresponding to maxSoldierLoad. It seems to possibly be a game bug that you can go over this limit.

[commy2]

Sure, but this does not change anything in this PR, does it?

[Freddo3000]

Not really, just adding additional details. Depending on whether the ticket is fixed later, this function may become redundant or invalid, though I wouldn't hold my breath at this stage of the game.