-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sqfc support #1450
Add sqfc support #1450
Conversation
I know it literally uses |
Open to suggestions |
I disabled compiling on
as they all have the basic format of
If A3 were to change these functions then it could cause issues because CBA would be stuck on a older version |
Huh? I don't get it. |
When compiling it will take the current version in your p-drive and "statically links" it into the sqfc By not compiling, it will do the |
Not a perfect solution though. Can't we mark it somehow in the script file that it should not be proessed like that? That seems more explicit and maintainable. |
JSON doesn't support comments for some reason it's just the few functions we hijack via |
This PR is ready so I'll merge, but it does not necessarily mean that next CBA release will be using compiled SQFC |
what is a problem to add compile stage to make.py? |
probably 1 line to call |
Just add |
No description provided.