Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing includes for SQFC #1473

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

Dahlgren
Copy link
Contributor

@Dahlgren Dahlgren commented Jul 12, 2021

When merged this pull request will:

  • Fix 43 failing compilations with ArmaScriptCompiler when using files in include folder

@commy2
Copy link
Contributor

commy2 commented Jul 12, 2021

urg

@PabstMirror
Copy link
Contributor

Looks like I meant to disable fn_isDebugConsoleAllowed but got it mixed up with fnc_initExtendedDebugConsole
so I can fix the sqfc.json and we don't need fn_isDebugConsoleAllowed in the /include

ref #1450 (comment)

@Dahlgren
Copy link
Contributor Author

Nice, one less file 🙂

@commy2
Copy link
Contributor

commy2 commented Jul 13, 2021

I don't like this. Who maintains these copy pasted files? Just pull them from the vanilla project files.

@jonpas
Copy link
Member

jonpas commented Jul 23, 2021

Commy, they are includes for build tools, so P-drive is not required. You don't have to use them.

@jonpas jonpas added the Tools label Jul 23, 2021
@jonpas jonpas added this to the 3.15.6 milestone Jul 23, 2021
@jonpas jonpas changed the title Add missing includes for sqfc Add missing includes for SQFC Jul 23, 2021
@jonpas jonpas merged commit d998c07 into CBATeam:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants