Fix CBA_fnc_mapGridToPos off by one
#1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With check-decrement ordering the while loops execute twice, leaving _minus at -2, then _rvOriginX/_rvOriginY get set to 0 + (abs - 2) - 1 = 1 (and get cached at GVAR(rvOriginX)/GVAR(rvOriginY)), then at line 176 said variables get subtracted from previous calculated coordinates
jonpas
changed the title
jonpas
approved these changes
Jun 24, 2023
jonpas
changed the title
CBA_fnc_mapGridToPos off by one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1362
With check-decrement ordering the while loops execute twice, leaving
_minusat -2, then_rvOriginX/_rvOriginYget set to0 + (abs - 2) - 1= 1 (and get cached atGVAR(rvOriginX)/GVAR(rvOriginY)), then at line 176 said variables get subtracted from previous calculated coordinates, leading to [-1, -1, 0] offset mentioned in the issue.Manual tests on Altis/Stratis/Malden/VR/Livonia seem to return proper results.
When merged this pull request will: