Add the ability to disable fnc_globalExecute #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mission makers and/or server managers can disable the use of CBA_fnc_globalExecute either by using a mission setting or an optional addon. When disabled, calling fnc_globalExecute does nothing. Fixes #269
| @@ -95,8 +93,38 @@ if (SLX_XEH_MACHINE select 3) then { | |||
| }; | |||
| }; | |||
|
|
|||
| // CBA_fnc_globalExecute is normally enabled | |||
| _disableGE = false; | |||
|
👍 for the optional pbo |
|
|
||
| [QUOTE(GVAR(cmd)), { if (GVAR(init)) then { _this spawn FUNC(exec) } }] call (uiNamespace getVariable "CBA_fnc_addEventHandler"); | ||
| if (_disableGE) then { | ||
| uiNamespace setVariable [QGVAR(exec), compileFinal ""]; |
There was a problem hiding this comment.
Should this be QUOTE(DFUNC(exec))?
I don't think we want to use uiNameSpace / caching for this function at all.
Otherwise I can create a mission with it disabled, and it will compileFinal the function to {} in UI
then join a server with it enabled and PREP will still pull the {}.
There was a problem hiding this comment.
Good point - the idea was to make sure "FUNC(exec)" cannot be used nor restored (by non-CBA means) while globalExecute is disabled.
|
looks good 👍 |
Killswitch00
added a commit
that referenced
this pull request
Feb 22, 2016
Add the ability to disable fnc_globalExecute
|
Good. Let's update the optionals section of README.md |
|
This needs more work to handle a few more...issues. (Discussed elsewhere) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mission makers and/or server managers can disable the use of
CBA_fnc_globalExecute either by using a mission setting or
an optional addon. When disabled, calling fnc_globalExecute
does nothing. Fixes #269