Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use remote exec in network #275

Merged
merged 3 commits into from
Feb 24, 2016
Merged

Use remote exec in network #275

merged 3 commits into from
Feb 24, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 24, 2016

alternative solution for #269 and #270

This way we can completely ignore all security things as they are handled by CfgRemoteExec and BI's / Battleyes security framework.

Also changes CBA_fnc_globalSay and CBA_fnc_globalSay3d to use remoteExecCall

test:

private _fnc_test = {sleep 1; systemChat str _this};

[-2, _fnc_test, "All"] call CBA_fnc_globalExecute;
[-1, _fnc_test, "ClientOnly"] call CBA_fnc_globalExecute;
[ 0, _fnc_test, "ServerOnly"] call CBA_fnc_globalExecute;
[[player], "Alarm"] call CBA_fnc_globalSay;
[[player], ["Alarm", 500, 1]] call CBA_fnc_globalSay;
[player, "Alarm"] call CBA_fnc_globalSay;
[player, "Alarm"] call CBA_fnc_globalSay3d;
[player, "Alarm", 500] call CBA_fnc_globalSay3d;

The function header of CBA_fnc_globalSay3d claims that you can use an array of objects as targets (similar to CBA_fnc_globalSay, probably copy paste ...). That was broken and caused a script error. Fixed now.

[[player], "Alarm"] call CBA_fnc_globalSay3d;

@Killswitch00
Copy link
Contributor

Much better than the hack I cooked up.

Killswitch00 added a commit that referenced this pull request Feb 24, 2016
@Killswitch00 Killswitch00 merged commit d01c168 into master Feb 24, 2016
@ViperMaul ViperMaul added this to the 2.3.2 milestone Feb 25, 2016
@thojkooi thojkooi deleted the use_remoteExec_in_network branch April 25, 2016 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants