-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix versioning #290
Fix versioning #290
Conversation
👍 |
Old code was doing this, as far as I know we still need the call compile to convert the string into a bool. |
It does not work when you compile a whole expression like here. |
OK I think I need a better explanation of what those lines are doing, because I am confused as hell... what is |
@NouberNou
@ViperMaul
into a boolean for the Tested with a dependency of |
missionNamespace setVariable ["_dependencyIsPresent", _dependencyInfo select 2]; | ||
private _dependencyIsPresent = call compile format ["%1", (_dependencyInfo select 2)]; | ||
if ((isNil "_dependencyIsPresent") || {!(_dependencyIsPresent isEqualType false)}) then { | ||
//https://dev.withsix.com/issues/74516 - The code could return non-bool, if "true" is converted to "1" durring binerization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
binarization
Fix versioning system
setVariable
doesn't seem to work on local variables.