Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CBA 2.3.1 to versioning check #3513

Merged
merged 3 commits into from
Mar 8, 2016
Merged

Add CBA 2.3.1 to versioning check #3513

merged 3 commits into from
Mar 8, 2016

Conversation

PabstMirror
Copy link
Contributor

Will require CBATeam/CBA_A3#290

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Mar 2, 2016
@PabstMirror PabstMirror added this to the 3.5.1 milestone Mar 2, 2016
@nicolasbadano
Copy link
Contributor

👍

@thojkooi
Copy link
Contributor

thojkooi commented Mar 2, 2016

What will this do if someone loads an incorrect CBA version?

Are those minimum versions or does it have to match the exact version?

@PabstMirror
Copy link
Contributor Author

Just the min version, so 2.3.2 or 3.0.0 would be fine.
It just puts a little systemChat warning.
Do we want a stronger warning, like closeDisplay on a ace version mismatch?

@bux
Copy link
Member

bux commented Mar 2, 2016

CheckPBO outputs a nice red box in the center of the screen. Maybe something like that.

class ACE_RscErrorHint {

https://github.com/acemod/ACE3/blob/master/addons/common/functions/fnc_checkPBOs.sqf#L74

@jonpas
Copy link
Member

jonpas commented Mar 2, 2016

What @bux578 said. Should be done in CBA though.

@PabstMirror
Copy link
Contributor Author

Now a hard stop if using an older version of CBA.
If we're counting on new stuff like cba_missionTime, there is no point trying to run on old versions of cba.

@commy2
Copy link
Contributor

commy2 commented Mar 2, 2016

👍
This is brilliant. Old glory of A2 is coming back.

@thojkooi
Copy link
Contributor

thojkooi commented Mar 8, 2016

Perfect, thanks @PabstMirror 👍

thojkooi added a commit that referenced this pull request Mar 8, 2016
Add CBA 2.3.1 to versioning check
@thojkooi thojkooi merged commit bfe738b into master Mar 8, 2016
@thojkooi thojkooi deleted the cbaVersioning branch March 8, 2016 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants