Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run missions preInit XEH on mission switch in 3DEN #624

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Mar 29, 2017

When merged this pull request will:

  • runs the missions XEH preInit eventhandlers every time a new mission is selected in the Eden-Editor ("OnMissionNew" and "OnMissionLoad")
  • moves "OnTerrainNew" fix to the 3DEN display load event, so the 3DEN eventhandler isn't repeatedly added by itself every time the terrain is switched in the Eden-Editor.
  • also renames 3DENDisplayLoad to initDisplay3DEN ("init" of "Display3DEN")

This isn't a perfect fix, because functions or settings defined in the missions preInit will still carry over to the new mission / loaded mission if the terrain was not switched. This fixes itself when the preview is used though. Currently using the preview would delete the carried over functions and settings and also initialize the new ones, so at least half the problem is gone.

@commy2 commy2 added this to the 3.3 milestone Mar 29, 2017
@commy2 commy2 merged commit adc70c5 into master Mar 29, 2017
@commy2 commy2 deleted the run-missions-preInit-on-mission-load branch March 29, 2017 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant