Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rebinding would delete default keyup handler #677

Merged
merged 1 commit into from
May 13, 2017
Merged

fix rebinding would delete default keyup handler #677

merged 1 commit into from
May 13, 2017

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented May 11, 2017 •
edited
Loading

When merged this pull request will:

  • The CBA_fnc_addKeyHandler for already existing actions has to be called before CBA_fnc_addKeyHandler for the "defaultuphandler", or otherwise keyDown stops working.

@commy2 commy2 added the Bug Fix label May 11, 2017
@commy2 commy2 added this to the 3.4 milestone May 11, 2017
@commy2 commy2 self-assigned this May 11, 2017
@commy2 commy2 mentioned this pull request May 11, 2017
Merged
@Killswitch00 Killswitch00 merged commit 17d02fc into keybinding May 13, 2017
@commy2 commy2 deleted the keybinding-fix-rebind branch May 13, 2017 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@commy2 commy2

Labels
Bug Fix
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@commy2 @Killswitch00