Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arbitrary character trimming #872

Closed
wants to merge 1 commit into from
Closed

Add support for arbitrary character trimming #872

wants to merge 1 commit into from

Conversation

kymckay
Copy link
Contributor

@kymckay kymckay commented Jan 11, 2018

When merged this pull request will:

  • Add support for arbitrary character trimming
  • This will also fix the functions for strings with non-ASCII characters where the toArray length is different from the length of the original string

Tested and working perfectly (tried with non-ASCII too)

This will also fix the functions for strings with non-ASCII characters
where the `toArray` length is different from the length of the original
string
@PabstMirror
Copy link
Contributor

Was failing these tests:

_str = ["   "] call CBA_fnc_leftTrim;
TEST_OP(_str,==,"",_fn);
_str = ["   "] call CBA_fnc_rightTrim;
TEST_OP(_str,==,"",_fn);
_str = [" 	"] call CBA_fnc_rightTrim; // including tabs
TEST_OP(_str,==,"",_fn);

I think this will fix: fa245be

@commy2 commy2 added this to the 3.7 milestone Feb 8, 2018
@commy2 commy2 added the Feature label Feb 8, 2018
@commy2 commy2 closed this in #889 Feb 13, 2018
@kymckay kymckay deleted the fixTrim branch February 14, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants