Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for arbitrary character trimming 2 #889

Merged
merged 3 commits into from
Feb 13, 2018
Merged

Add support for arbitrary character trimming 2 #889

merged 3 commits into from
Feb 13, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 13, 2018

When merged this pull request will:

I fixed this test:

execVM "\x\cba\addons\strings\test_strings.sqf"

kymckay and others added 3 commits January 11, 2018 18:12
@kymckay
Add support for arbitrary character trimming
e8488a4 
This will also fix the functions for strings with non-ASCII characters
where the `toArray` length is different from the length of the original
string
@commy2
Merge branch 'fixTrim' of https://github.com/SilentSpike/CBA_A3 into …
deafe5f 
…SilentSpike-fixTrim
@commy2
fix tests for pure whitespace examples
12c09e0
@commy2 commy2 added the Feature label Feb 13, 2018
@commy2 commy2 added this to the 3.7 milestone Feb 13, 2018
@commy2 commy2 changed the title Silent spike fix trim Add support for arbitrary character trimming 2 Feb 13, 2018
@commy2 commy2 merged commit 91c8e89 into master Feb 13, 2018
@commy2 commy2 deleted the SilentSpike-fixTrim branch February 13, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@commy2 @jonpas @kymckay